minor rewordings

Author: pm47

eclair-core/src/main/resources/reference.conf

@@ -86,8 +86,9 @@ eclair {
   fulfill-safety-before-timeout-blocks = 24
   min-final-expiry-delta-blocks = 30 // Bolt 11 invoice's min_final_cltv_expiry; must be strictly greater than fulfill-safety-before-timeout-blocks
   max-block-processing-delay = 30 seconds // we add a random delay before processing blocks, capped at this value, to prevent herd effect
-  outdated-commitment-strategy = "always-request-remote-close" // always-request-remote-close or halt-if-just-restarted
-  unhandled-exception-strategy = "local-force-close" // local-force-close or log-and-stop
+
+  outdated-commitment-strategy = "remote-close" // remote-close or stop (NB: the app will only stop if it was recently restarted)
+  unhandled-exception-strategy = "local-close" // local-close or stop
 
   fee-base-msat = 1000
   fee-proportional-millionths = 100 // fee charged per transferred satoshi in millionths of a satoshi (100 = 0.01%)

eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala

@@ -298,13 +298,13 @@ object NodeParams extends Logging {
     require(feeBase <= MilliSatoshi(0xFFFFFFFFL), "fee-base-msat must be below 42 mbtc")
 
     val outdatedCommitmentStrategy = config.getString("outdated-commitment-strategy") match {
-      case "halt-if-just-restarted" => OutdatedCommitmentStrategy.HaltIfJustRestarted
-      case "always-request-remote-close" => OutdatedCommitmentStrategy.AlwaysRequestRemoteClose
+      case "remote-close" => OutdatedCommitmentStrategy.RemoteClose
+      case "stop" => OutdatedCommitmentStrategy.Stop
     }
 
     val unhandledExceptionStrategy = config.getString("unhandled-exception-strategy") match {
-        case "local-force-close" => UnhandledExceptionStrategy.LocalForceClose
-        case "log-and-stop" => UnhandledExceptionStrategy.LogAndStop
+        case "local-close" => UnhandledExceptionStrategy.LocalClose
+        case "stop" => UnhandledExceptionStrategy.Stop
       }
 
     val routerSyncEncodingType = config.getString("router.sync.encoding-type") match {

eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala

@@ -136,15 +136,15 @@ object Channel {
      * that we are using an outdated commitment.
      * This may be the best choice for smaller loosely administered nodes.
      */
-    case object AlwaysRequestRemoteClose extends OutdatedCommitmentStrategy
+    case object RemoteClose extends OutdatedCommitmentStrategy
     /**
      * If the node was just restarted, just log an error and stop the app. The goal is to prevent unwanted mass
      * force-close of channels if we accidentally restarted the node with an outdated backup. After a few minutes, we
      * revert to the default behavior of requesting our peer to force close, otherwise this opens a huge attack vector
      * where any peer can remotely stop our node.
      * This strategy may be better suited for larger nodes, closely administered.
      */
-    case object HaltIfJustRestarted extends OutdatedCommitmentStrategy
+    case object Stop extends OutdatedCommitmentStrategy
   }
   // @formatter:on
 
@@ -153,9 +153,9 @@ object Channel {
   sealed trait UnhandledExceptionStrategy
   object UnhandledExceptionStrategy {
     /** Ask our counterparty to close the channel. This may be the best choice for smaller loosely administered nodes.*/
-    case object LocalForceClose extends UnhandledExceptionStrategy
+    case object LocalClose extends UnhandledExceptionStrategy
     /** Just log an error and stop the node. May be better for larger nodes, to prevent unwanted mass force-close.*/
-    case object LogAndStop extends UnhandledExceptionStrategy
+    case object Stop extends UnhandledExceptionStrategy
   }
   // @formatter:on
 
@@ -2196,9 +2196,9 @@ class Channel(val nodeParams: NodeParams, val wallet: EclairWallet, remoteNodeId
           case _ =>
             // unhandled exception: we apply the configured strategy
             nodeParams.unhandledExceptionStrategy match {
-              case UnhandledExceptionStrategy.LocalForceClose =>
+              case UnhandledExceptionStrategy.LocalClose =>
                 spendLocalCurrent(dd) sending error
-              case UnhandledExceptionStrategy.LogAndStop =>
+              case UnhandledExceptionStrategy.Stop =>
                 log.error("stopping the node (unhandled exception")
                 System.exit(1)
                 stop(FSM.Shutdown)
@@ -2446,11 +2446,11 @@ class Channel(val nodeParams: NodeParams, val wallet: EclairWallet, remoteNodeId
 
   private def handleOutdatedCommitment(channelReestablish: ChannelReestablish, d: HasCommitments) = {
     nodeParams.outdatedCommitmentStrategy match {
-      case OutdatedCommitmentStrategy.HaltIfJustRestarted if ManagementFactory.getRuntimeMXBean.getUptime.millis < 10.minutes =>
+      case OutdatedCommitmentStrategy.Stop if ManagementFactory.getRuntimeMXBean.getUptime.millis < 10.minutes =>
         log.error("we just restarted and may have an outdated commitment! stopping the node")
         System.exit(1)
         stop(FSM.Shutdown)
-      case OutdatedCommitmentStrategy.AlwaysRequestRemoteClose =>
+      case OutdatedCommitmentStrategy.RemoteClose =>
         val exc = PleasePublishYourCommitment(d.channelId)
         val error = Error(d.channelId, exc.getMessage)
         goto(WAIT_FOR_REMOTE_PUBLISH_FUTURE_COMMITMENT) using DATA_WAIT_FOR_REMOTE_PUBLISH_FUTURE_COMMITMENT(d.commitments, channelReestablish) storing() sending error

eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala

@@ -121,8 +121,8 @@ object TestConstants {
       feeProportionalMillionth = 10,
       reserveToFundingRatio = 0.01, // note: not used (overridden below)
       maxReserveToFundingRatio = 0.05,
-      outdatedCommitmentStrategy = OutdatedCommitmentStrategy.AlwaysRequestRemoteClose,
-      unhandledExceptionStrategy = UnhandledExceptionStrategy.LocalForceClose,
+      outdatedCommitmentStrategy = OutdatedCommitmentStrategy.RemoteClose,
+      unhandledExceptionStrategy = UnhandledExceptionStrategy.LocalClose,
       db = TestDatabases.inMemoryDb(),
       revocationTimeout = 20 seconds,
       autoReconnect = false,
@@ -228,8 +228,8 @@ object TestConstants {
       feeProportionalMillionth = 10,
       reserveToFundingRatio = 0.01, // note: not used (overridden below)
       maxReserveToFundingRatio = 0.05,
-      outdatedCommitmentStrategy = OutdatedCommitmentStrategy.AlwaysRequestRemoteClose,
-      unhandledExceptionStrategy = UnhandledExceptionStrategy.LocalForceClose,
+      outdatedCommitmentStrategy = OutdatedCommitmentStrategy.RemoteClose,
+      unhandledExceptionStrategy = UnhandledExceptionStrategy.LocalClose,
       db = TestDatabases.inMemoryDb(),
       revocationTimeout = 20 seconds,
       autoReconnect = false,