WIP: add Agent Skill support #787
Conversation
|
WalkthroughThis changeset introduces a new "agentic" agent type that extends the existing AI agent framework with advanced task execution capabilities. The implementation includes a skill system for loading external agent capabilities, built-in tools for file operations and bash execution, and a planner sub-agent for breaking down complex objectives. The changes span core agent implementation, YAML configuration support, and loader updates to handle the new agent type. Changes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (3)
- packages/core/src/agents/agentic-agent.ts (1)
- packages/core/src/loader/agent-yaml.ts (3)
- packages/core/src/loader/index.ts (2)
Files ignored due to filter (2)
- packages/core/package.json
- pnpm-lock.yaml
Review comments generated (16)
- Review: 11
- LGTM: 5
提示
与 
AIGNE CodeSmith (@codesmith) 聊天
- 回复此机器人留下的审查评论以提出后续问题。审查评论是对差异或文件的评论。
- 通过在回复中标记
@codesmith邀请机器人加入审查评论链。
代码建议
- 机器人可能会提出代码建议，但在提交前请仔细审查它们，因为行号范围可能会不对齐。
- 你可以编辑机器人做出的评论，并在建议稍有偏差时手动调整。
暂停增量审查
- 在 PR 描述中的任何位置添加
@codesmith: ignore以暂停机器人的进一步审查。
| console.log("GrepTool stdout:", data.toString()); | ||
| controller.enqueue({ delta: { text: { matches: data.toString() } } }); |
There was a problem hiding this comment.
Debug console.log statements should be removed from production code.
- console.log("GrepTool stdout:", data.toString());| console.log("GrepTool stderr:", data.toString()); | ||
| controller.enqueue({ delta: { text: { error: data.toString() } } }); |
There was a problem hiding this comment.
Debug console.log statements should be removed from production code.
- console.log("GrepTool stderr:", data.toString());| console.log("GrepTool process closed with code:", code); | ||
| if (typeof code === "number") { |
There was a problem hiding this comment.
Debug console.log statements should be removed from production code.
- console.log("GrepTool process closed with code:", code);| console.log("GrepTool process error:", error); | ||
| controller.enqueue({ |
There was a problem hiding this comment.
Debug console.log statements should be removed from production code.
- console.log("GrepTool process error:", error);| async function loadAgentSkills() { | ||
| const skills: AgentSkill[] = []; | ||
|
|
||
| const root = resolve("/Users/chao/.claude/plugins/marketplaces/anthropic-agent-skills"); |
There was a problem hiding this comment.
Hardcoded path should not be used in production code. This creates a security vulnerability and makes the code non-portable.
- const root = resolve("/Users/chao/.claude/plugins/marketplaces/anthropic-agent-skills");| controller.enqueue({ delta: { json: { success: true } } }); | ||
| } catch (error) { | ||
| controller.enqueue({ | ||
| delta: { text: { error: `Failed to write file: ${error.message}` } }, |
There was a problem hiding this comment.
Error message access is unsafe - error might not have a message property.
- delta: { text: { error: `Failed to write file: ${error.message}` } },
+ delta: { text: { error: `Failed to write file: ${error instanceof Error ? error.message : String(error)}` } },| rg.on("error", (error) => { | ||
| console.log("GrepTool process error:", error); | ||
| controller.enqueue({ | ||
| delta: { text: { error: `Failed to spawn ripgrep: ${error.message}` } }, |
There was a problem hiding this comment.
Error message access is unsafe - error might not have a message property.
- delta: { text: { error: `Failed to spawn ripgrep: ${error.message}` } },
+ delta: { text: { error: `Failed to spawn ripgrep: ${error instanceof Error ? error.message : String(error)}` } },| }); | ||
| } catch (error) { | ||
| controller.enqueue({ | ||
| delta: { text: { error: `GrepTool encountered an error: ${error.message}` } }, |
There was a problem hiding this comment.
Error message access is unsafe - error might not have a message property.
- delta: { text: { error: `GrepTool encountered an error: ${error.message}` } },
+ delta: { text: { error: `GrepTool encountered an error: ${error instanceof Error ? error.message : String(error)}` } },| } | ||
| } catch (error) { | ||
| controller.enqueue({ | ||
| delta: { text: { error: `Failed to glob files: ${error.message}` } }, |
There was a problem hiding this comment.
Error message access is unsafe - error might not have a message property.
- delta: { text: { error: `Failed to glob files: ${error.message}` } },
+ delta: { text: { error: `Failed to glob files: ${error instanceof Error ? error.message : String(error)}` } },| }); | ||
|
|
||
| child.on("error", (error) => { | ||
| controller.enqueue({ delta: { text: { stderr: error.message } } }); |
There was a problem hiding this comment.
Error message access is unsafe - error might not have a message property.
- controller.enqueue({ delta: { text: { stderr: error.message } } });
+ controller.enqueue({ delta: { text: { stderr: error instanceof Error ? error.message : String(error) } } });
Related Issue
Major Changes
Screenshots
Test Plan
Checklist
Summary by AIGNE
Release Notes
New Feature
Chore