Skip to content

value of do_hydro used before it is read in by read_hydro_params() #89

@n8xm

Description

@n8xm

On Line 308 of Nyx.cpp, the value of do_hydro is used in the following if statement :

  if (DefaultGeometry().isAnyPeriodic() || (!do_dm_particles && !do_hydro))

However, this if statement comes before the actual call to read_hydro_params(), which sets the value of do_hydro given the input file. I suspect that !do_hydro above always evaluates to true because its default value is zero.

If I am correct, then && !do_hydro should be removed from the if statement.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions