Remove accesskit_custom_action_new_with_length, add comments specifying ownership

Author: TheZipCreator

include/accesskit.h

@@ -869,8 +869,7 @@ typedef struct accesskit_opt_text_selection {
 } accesskit_opt_text_selection;
 
 /**
- * Use `accesskit_custom_action_new` or
- * `accesskit_custom_action_new_with_length` to create this struct. Do not
+ * Use `accesskit_custom_action_new` or to create this struct. Do not
  * reallocate `description`.
  *
  * When you get this struct, you are responsible for freeing `description`.
@@ -2092,12 +2091,6 @@ void accesskit_node_clear_text_selection(struct accesskit_node *node);
 struct accesskit_custom_action accesskit_custom_action_new(
     int32_t id, const char *description);
 
-/**
- * The string must not contain null bytes.
- */
-struct accesskit_custom_action accesskit_custom_action_new_with_length(
-    int32_t id, size_t length, const char *description);
-
 void accesskit_custom_actions_free(struct accesskit_custom_actions *value);
 
 /**
@@ -2131,9 +2124,15 @@ void accesskit_tree_free(struct accesskit_tree *tree);
  */
 char *accesskit_tree_get_toolkit_name(const struct accesskit_tree *tree);
 
+/**
+ * Caller is responsible for freeing the memory pointed by `toolkit_name`
+ */
 void accesskit_tree_set_toolkit_name(struct accesskit_tree *tree,
                                      const char *toolkit_name);
 
+/**
+ * Caller is responsible for freeing the memory pointed by `toolkit_name`
+ */
 void accesskit_tree_set_toolkit_name_with_length(struct accesskit_tree *tree,
                                                  size_t length,
                                                  const char *toolkit_name);
@@ -2145,9 +2144,15 @@ void accesskit_tree_clear_toolkit_name(struct accesskit_tree *tree);
  */
 char *accesskit_tree_get_toolkit_version(const struct accesskit_tree *tree);
 
+/**
+ * Caller is responsible for freeing the memory pointed by `toolkit_version`
+ */
 void accesskit_tree_set_toolkit_version(struct accesskit_tree *tree,
                                         const char *toolkit_version);
 
+/**
+ * Caller is responsible for freeing the memory pointed by `toolkit_version`
+ */
 void accesskit_tree_set_toolkit_version_with_length(
     struct accesskit_tree *tree, size_t length, const char *toolkit_version);
 

src/common.rs

@@ -665,8 +665,7 @@ impl node {
 }
 clearer! { accesskit_node_clear_text_selection, clear_text_selection }
 
-/// Use `accesskit_custom_action_new` or 
-/// `accesskit_custom_action_new_with_length` to create this struct. Do not 
+/// Use `accesskit_custom_action_new` or to create this struct. Do not
 /// reallocate `description`.
 ///
 /// When you get this struct, you are responsible for freeing `description`.
@@ -692,23 +691,6 @@ impl custom_action {
             description: description.into_raw(),
         }
     }
-    
-    /// The string must not contain null bytes.
-    #[no_mangle]
-    pub extern "C" fn accesskit_custom_action_new_with_length(
-        id: i32,
-        length: usize,
-        description: *const c_char,
-    ) -> custom_action {
-        let description = CString::new(String::from_utf8_lossy(
-            unsafe { slice::from_raw_parts(description as *const u8, length) }
-        ).into_owned())
-        .unwrap();
-        Self {
-            id,
-            description: description.into_raw(),
-        }
-    }
 }
 
 impl Drop for custom_action {
@@ -795,6 +777,7 @@ impl tree {
         }
     }
 
+    /// Caller is responsible for freeing the memory pointed by `toolkit_name`
     #[no_mangle]
     pub extern "C" fn accesskit_tree_set_toolkit_name(
         tree: *mut tree,
@@ -806,6 +789,7 @@ impl tree {
         ));
     }
 
+    /// Caller is responsible for freeing the memory pointed by `toolkit_name`
     #[no_mangle]
     pub extern "C" fn accesskit_tree_set_toolkit_name_with_length(
         tree: *mut tree,
@@ -834,6 +818,7 @@ impl tree {
         }
     }
 
+    /// Caller is responsible for freeing the memory pointed by `toolkit_version`
     #[no_mangle]
     pub extern "C" fn accesskit_tree_set_toolkit_version(
         tree: *mut tree,
@@ -845,6 +830,7 @@ impl tree {
         ));
     }
 
+    /// Caller is responsible for freeing the memory pointed by `toolkit_version`
     #[no_mangle]
     pub extern "C" fn accesskit_tree_set_toolkit_version_with_length(
         tree: *mut tree,