Merge pull request #42 from AikidoSec/fix/fail-on-wrong-input

willem-delbare · web-flow · commit 15f95c7a81de · 2024-03-29T12:47:03.000+01:00
let action fail when invalid input is provided
diff --git a/dist/index.js b/dist/index.js
@@ -132,13 +132,13 @@ async function run() {
         let postScanStatusAsComment = core.getInput('post-scan-status-comment');
         if (!['LOW', 'MEDIUM', 'HIGH', 'CRITICAL'].includes(fromSeverity.toUpperCase())) {
             core.setOutput('output', STATUS_FAILED);
-            core.info(`Invalid property value for minimum-severity. Allowed values are: LOW, MEDIUM, HIGH, CRITICAL`);
+            core.setFailed(`Invalid property value for minimum-severity. Allowed values are: LOW, MEDIUM, HIGH, CRITICAL`);
             return;
         }
         postScanStatusAsComment = (0, transformPostScanStatusAsComment_1.transformPostScanStatusAsComment)(postScanStatusAsComment);
         if (!ALLOWED_POST_SCAN_STATUS_OPTIONS.includes(postScanStatusAsComment)) {
             core.setOutput('ouput', STATUS_FAILED);
-            core.error(`Invalid property value for post-scan-status-comment. Allowed values are: ${ALLOWED_POST_SCAN_STATUS_OPTIONS.join(', ')}`);
+            core.setFailed(`Invalid property value for post-scan-status-comment. Allowed values are: ${ALLOWED_POST_SCAN_STATUS_OPTIONS.join(', ')}`);
             return;
         }
         const startScanPayload = {
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/main.ts b/src/main.ts
@@ -25,14 +25,14 @@ async function run(): Promise<void> {
 
 		if (!['LOW', 'MEDIUM', 'HIGH', 'CRITICAL'].includes(fromSeverity.toUpperCase())) {
 			core.setOutput('output', STATUS_FAILED);
-			core.info(`Invalid property value for minimum-severity. Allowed values are: LOW, MEDIUM, HIGH, CRITICAL`);
+			core.setFailed(`Invalid property value for minimum-severity. Allowed values are: LOW, MEDIUM, HIGH, CRITICAL`);
 			return;
 		}
 
 		postScanStatusAsComment = transformPostScanStatusAsComment(postScanStatusAsComment);
 		if (!ALLOWED_POST_SCAN_STATUS_OPTIONS.includes(postScanStatusAsComment)) {
 			core.setOutput('ouput', STATUS_FAILED);
-			core.error(`Invalid property value for post-scan-status-comment. Allowed values are: ${ALLOWED_POST_SCAN_STATUS_OPTIONS.join(', ')}`);
+			core.setFailed(`Invalid property value for post-scan-status-comment. Allowed values are: ${ALLOWED_POST_SCAN_STATUS_OPTIONS.join(', ')}`);
 			return;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -25,14 +25,14 @@ async function run(): Promise<void> {`
`25`	`25`
`26`	`26`	`if (!['LOW', 'MEDIUM', 'HIGH', 'CRITICAL'].includes(fromSeverity.toUpperCase())) {`
`27`	`27`	`core.setOutput('output', STATUS_FAILED);`
`28`		- core.info(`Invalid property value for minimum-severity. Allowed values are: LOW, MEDIUM, HIGH, CRITICAL`);
	`28`	+ core.setFailed(`Invalid property value for minimum-severity. Allowed values are: LOW, MEDIUM, HIGH, CRITICAL`);
`29`	`29`	`return;`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`postScanStatusAsComment = transformPostScanStatusAsComment(postScanStatusAsComment);`
`33`	`33`	`if (!ALLOWED_POST_SCAN_STATUS_OPTIONS.includes(postScanStatusAsComment)) {`
`34`	`34`	`core.setOutput('ouput', STATUS_FAILED);`
`35`		- core.error(`Invalid property value for post-scan-status-comment. Allowed values are: ${ALLOWED_POST_SCAN_STATUS_OPTIONS.join(', ')}`);
	`35`	+ core.setFailed(`Invalid property value for post-scan-status-comment. Allowed values are: ${ALLOWED_POST_SCAN_STATUS_OPTIONS.join(', ')}`);
`36`	`36`	`return;`
`37`	`37`	`}`
`38`	`38`