Skip to content

Commit e345758

Browse files
committed
Fixed compile
1 parent d9fc9db commit e345758

File tree

6 files changed

+28
-24
lines changed

6 files changed

+28
-24
lines changed

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/config/BigQuerySinkConfig.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1214,6 +1214,10 @@ public boolean isUpsertDeleteEnabled() {
12141214
return getBoolean(UPSERT_ENABLED_CONFIG) || getBoolean(DELETE_ENABLED_CONFIG);
12151215
}
12161216

1217+
public boolean isIgnoreUnknownFields() {
1218+
return getBoolean(BigQuerySinkConfig.IGNORE_UNKNOWN_FIELDS_CONFIG);
1219+
}
1220+
12171221
public Optional<TimePartitioning.Type> getTimePartitioningType() {
12181222
return parseTimePartitioningType(getString(TIME_PARTITIONING_TYPE_CONFIG));
12191223
}

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/write/row/AdaptiveBigQueryWriter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,17 @@ public AdaptiveBigQueryWriter(BigQuery bigQuery,
8686
}
8787

8888
/**
89-
* @deprecated This constructor does not support configuration of additional write settings.
90-
* Use {@link #AdaptiveBigQueryWriter(BigQuery bigQuery, SchemaManager schemaManager, int retry, long retryWait,
91-
* boolean autoCreateTables, ErrantRecordHandler errantRecordHandler, Time time, BigQuerySinkConfig config)}.
92-
*
9389
* @param bigQuery Used to send write requests to BigQuery.
9490
* @param schemaManager Used to update BigQuery tables.
9591
* @param retry How many retries to make in the event of a 500/503 error.
9692
* @param retryWait How long to wait in between retries.
9793
* @param autoCreateTables Whether tables should be automatically created
9894
* @param errantRecordHandler Used to handle errant records
9995
* @param time used to wait during backoff periods
96+
*
97+
* @deprecated This constructor does not support configuration of additional write settings.
98+
* Use {@link #AdaptiveBigQueryWriter(BigQuery bigQuery, SchemaManager schemaManager, int retry, long retryWait,
99+
* boolean autoCreateTables, ErrantRecordHandler errantRecordHandler, Time time, BigQuerySinkConfig config)}.
100100
*/
101101
@Deprecated
102102
public AdaptiveBigQueryWriter(BigQuery bigQuery,

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/write/row/BigQueryWriter.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,20 +75,20 @@ public BigQueryWriter(int retries, long retryWaitMs, ErrantRecordHandler errantR
7575
this.random = new Random();
7676
this.errantRecordHandler = errantRecordHandler;
7777
this.time = time;
78-
this.ignoreUnknownFields = config.getBoolean(BigQuerySinkConfig.IGNORE_UNKNOWN_FIELDS_CONFIG);
78+
this.ignoreUnknownFields = config.isIgnoreUnknownFields();
7979
}
8080

8181
/**
82-
* @deprecated This constructor does not support configuration of additional write settings.
83-
* Use {@link #BigQueryWriter(int retries, long retryWaitMs, ErrantRecordHandler errantRecordHandler,
84-
* Time time, BigQuerySinkConfig config)} instead.
85-
*
8682
* @param retries the number of times to retry a request if BQ returns an internal service error
8783
* or a service unavailable error.
8884
* @param retryWaitMs the amount of time to wait in between reattempting a request if BQ returns
8985
* an internal service error or a service unavailable error.
9086
* @param errantRecordHandler used to handle errant records
9187
* @param time used to wait during backoff periods
88+
*
89+
* @deprecated This constructor does not support configuration of additional write settings.
90+
* Use {@link #BigQueryWriter(int retries, long retryWaitMs, ErrantRecordHandler errantRecordHandler,
91+
* Time time, BigQuerySinkConfig config)} instead.
9292
*/
9393
@Deprecated
9494
public BigQueryWriter(int retries, long retryWaitMs, ErrantRecordHandler errantRecordHandler, Time time) {

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/write/row/SimpleBigQueryWriter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ public SimpleBigQueryWriter(BigQuery bigQuery, int retry, long retryWait, Errant
6363
}
6464

6565
/**
66-
* @deprecated This constructor does not support configuration of additional write settings.
67-
* Use {@link #SimpleBigQueryWriter(BigQuery bigQuery, int retry, long retryWait, ErrantRecordHandler errantRecordHandler,
68-
* Time time, BigQuerySinkConfig config)}.
69-
*
7066
* @param bigQuery The object used to send write requests to BigQuery.
7167
* @param retry How many retries to make in the event of a 500/503 error.
7268
* @param retryWait How long to wait in between retries.
7369
* @param errantRecordHandler Used to handle errant records
7470
* @param time used to wait during backoff periods
71+
*
72+
* @deprecated This constructor does not support configuration of additional write settings.
73+
* Use {@link #SimpleBigQueryWriter(BigQuery bigQuery, int retry, long retryWait, ErrantRecordHandler errantRecordHandler,
74+
* Time time, BigQuerySinkConfig config)}.
7575
*/
7676
@Deprecated
7777
public SimpleBigQueryWriter(BigQuery bigQuery, int retry, long retryWait, ErrantRecordHandler errantRecordHandler,

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/write/row/UpsertDeleteBigQueryWriter.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ public UpsertDeleteBigQueryWriter(BigQuery bigQuery,
7777
}
7878

7979
/**
80-
* @deprecated This constructor does not support configuration of additional write settings.
81-
* Use {@link #UpsertDeleteBigQueryWriter(BigQuery bigQuery, SchemaManager schemaManager, int retry,
82-
* long retryWait, boolean autoCreateTables, Map intermediateToDestinationTables,
83-
* ErrantRecordHandler errantRecordHandler, Time time, BigQuerySinkConfig config)} instead.
84-
*
8580
* @param bigQuery Used to send write requests to BigQuery.
8681
* @param schemaManager Used to update BigQuery tables.
8782
* @param retry How many retries to make in the event of a 500/503 error.
@@ -93,6 +88,11 @@ public UpsertDeleteBigQueryWriter(BigQuery bigQuery,
9388
* table
9489
* @param errantRecordHandler Used to handle errant records
9590
* @param time used to wait during backoff periods
91+
*
92+
* @deprecated This constructor does not support configuration of additional write settings.
93+
* Use {@link #UpsertDeleteBigQueryWriter(BigQuery bigQuery, SchemaManager schemaManager, int retry,
94+
* long retryWait, boolean autoCreateTables, Map intermediateToDestinationTables,
95+
* ErrantRecordHandler errantRecordHandler, Time time, BigQuerySinkConfig config)} instead.
9696
*/
9797
@Deprecated
9898
public UpsertDeleteBigQueryWriter(BigQuery bigQuery,

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/write/storage/StorageWriteApiBase.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ protected StorageWriteApiBase(int retry,
9898
this.errantRecordHandler = errantRecordHandler;
9999
this.schemaManager = schemaManager;
100100
this.attemptSchemaUpdate = attemptSchemaUpdate;
101-
this.ignoreUnknownFields = config.getBoolean(BigQuerySinkConfig.IGNORE_UNKNOWN_FIELDS_CONFIG);
101+
this.ignoreUnknownFields = config.isIgnoreUnknownFields();
102102
try {
103103
this.writeClient = getWriteClient();
104104
} catch (IOException e) {
@@ -110,16 +110,16 @@ protected StorageWriteApiBase(int retry,
110110
}
111111

112112
/**
113-
* @deprecated This constructor does not support does not support configuration of additional write settings.
114-
* Use {@link #StorageWriteApiBase(int retry, long retryWait, BigQueryWriteSettings writeSettings,
115-
* boolean autoCreateTables, ErrantRecordHandler errantRecordHandler, SchemaManager schemaManager,
116-
* boolean attemptSchemaUpdate, BigQuerySinkConfig config)} instead.
117-
*
118113
* @param retry How many retries to make in the event of a retriable error.
119114
* @param retryWait How long to wait in between retries.
120115
* @param writeSettings Write Settings for stream which carry authentication and other header information
121116
* @param autoCreateTables boolean flag set if table should be created automatically
122117
* @param errantRecordHandler Used to handle errant records
118+
*
119+
* @deprecated This constructor does not support does not support configuration of additional write settings.
120+
* Use {@link #StorageWriteApiBase(int retry, long retryWait, BigQueryWriteSettings writeSettings,
121+
* boolean autoCreateTables, ErrantRecordHandler errantRecordHandler, SchemaManager schemaManager,
122+
* boolean attemptSchemaUpdate, BigQuerySinkConfig config)} instead.
123123
*/
124124
@Deprecated
125125
protected StorageWriteApiBase(int retry,

0 commit comments

Comments
 (0)