From c69175613c4aae55e052abbc0d0577e595189c19 Mon Sep 17 00:00:00 2001 From: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com> Date: Mon, 23 Jun 2025 16:35:08 +0100 Subject: [PATCH 1/2] chore: add network chain id 2 --- src/main/java/org/arkecosystem/crypto/networks/Devnet.java | 4 ++++ src/main/java/org/arkecosystem/crypto/networks/INetwork.java | 2 ++ src/main/java/org/arkecosystem/crypto/networks/Mainnet.java | 4 ++++ src/main/java/org/arkecosystem/crypto/networks/Testnet.java | 4 ++++ .../java/org/arkecosystem/crypto/networks/DevnetTest.java | 5 +++++ .../java/org/arkecosystem/crypto/networks/MainnetTest.java | 5 +++++ .../java/org/arkecosystem/crypto/networks/TestnetTest.java | 5 +++++ 7 files changed, 29 insertions(+) diff --git a/src/main/java/org/arkecosystem/crypto/networks/Devnet.java b/src/main/java/org/arkecosystem/crypto/networks/Devnet.java index ff89bd8a..d7d60f55 100644 --- a/src/main/java/org/arkecosystem/crypto/networks/Devnet.java +++ b/src/main/java/org/arkecosystem/crypto/networks/Devnet.java @@ -2,6 +2,10 @@ public class Devnet implements INetwork { + public int chainId() { + return 11812; + } + public int version() { return 30; } diff --git a/src/main/java/org/arkecosystem/crypto/networks/INetwork.java b/src/main/java/org/arkecosystem/crypto/networks/INetwork.java index cfc01482..38736a24 100644 --- a/src/main/java/org/arkecosystem/crypto/networks/INetwork.java +++ b/src/main/java/org/arkecosystem/crypto/networks/INetwork.java @@ -2,6 +2,8 @@ public interface INetwork { + int chainId(); + int version(); int wif(); diff --git a/src/main/java/org/arkecosystem/crypto/networks/Mainnet.java b/src/main/java/org/arkecosystem/crypto/networks/Mainnet.java index 2f3bbb59..7a46e074 100644 --- a/src/main/java/org/arkecosystem/crypto/networks/Mainnet.java +++ b/src/main/java/org/arkecosystem/crypto/networks/Mainnet.java @@ -2,6 +2,10 @@ public class Mainnet implements INetwork { + public int chainId() { + return 11811; + } + public int version() { return 23; } diff --git a/src/main/java/org/arkecosystem/crypto/networks/Testnet.java b/src/main/java/org/arkecosystem/crypto/networks/Testnet.java index 0066e500..3118588a 100644 --- a/src/main/java/org/arkecosystem/crypto/networks/Testnet.java +++ b/src/main/java/org/arkecosystem/crypto/networks/Testnet.java @@ -2,6 +2,10 @@ public class Testnet implements INetwork { + public int chainId() { + return 11812; + } + public int version() { return 23; } diff --git a/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java b/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java index 81c490d3..aae68739 100644 --- a/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java +++ b/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java @@ -6,6 +6,11 @@ class DevnetTest { + @Test + void chainId() { + assertEquals(11812, new Devnet().chainId()); + } + @Test void version() { assertEquals(0x1E, new Devnet().version()); diff --git a/src/test/java/org/arkecosystem/crypto/networks/MainnetTest.java b/src/test/java/org/arkecosystem/crypto/networks/MainnetTest.java index 5e1f3c9a..7071a9e0 100644 --- a/src/test/java/org/arkecosystem/crypto/networks/MainnetTest.java +++ b/src/test/java/org/arkecosystem/crypto/networks/MainnetTest.java @@ -6,6 +6,11 @@ class MainnetTest { + @Test + void chainId() { + assertEquals(11811, new Mainnet().chainId()); + } + @Test void version() { assertEquals(0x17, new Mainnet().version()); diff --git a/src/test/java/org/arkecosystem/crypto/networks/TestnetTest.java b/src/test/java/org/arkecosystem/crypto/networks/TestnetTest.java index d31e0139..7e1ac6c9 100644 --- a/src/test/java/org/arkecosystem/crypto/networks/TestnetTest.java +++ b/src/test/java/org/arkecosystem/crypto/networks/TestnetTest.java @@ -6,6 +6,11 @@ class TestnetTest { + @Test + void chainId() { + assertEquals(11812, new Testnet().chainId()); + } + @Test void version() { assertEquals(0x17, new Testnet().version()); From 2ee81ca45519f1b39d31e7b0cee13b3874e0e8a7 Mon Sep 17 00:00:00 2001 From: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com> Date: Mon, 23 Jun 2025 16:39:16 +0100 Subject: [PATCH 2/2] update workflow action versions --- .github/workflows/release.yml | 2 +- .github/workflows/test.yml | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ab13ee3b..b2c71dab 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -18,7 +18,7 @@ jobs: packages: write steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Set up Java uses: actions/setup-java@v2 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8cbb1b12..9f41db1e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Set up Java 17 uses: actions/setup-java@v3 @@ -29,25 +29,25 @@ jobs: run: ./gradlew test jacocoTestReport - name: Upload Test Results - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: test-results path: build/reports/tests/test - name: Upload Coverage Report - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: code-coverage-report path: build/reports/jacoco/test/html - name: Upload Jacoco XML Report - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: jacoco-xml-report path: build/reports/jacoco/test/jacocoTestReport.xml - name: Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} files: build/reports/jacoco/test/jacocoTestReport.xml