fix: skip recipient id in toBytes for tx type 1 and 4 (#18)

* fix: skip recipient id in toBytes for type 1 and 4

* chore: 0.2.3 changelog

Author: spkjp

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
+## 0.2.3
+
+### Fixed
+- Skip recipient id in `toBytes` for type 1 and 4 transactions.
+
 ## 0.2.2 - 2018-07-31
 
 ### Fixed

src/Transactions/Transaction.php

@@ -181,7 +181,8 @@ public function toBytes(bool $skipSignature = true, bool $skipSecondSignature =
         $buffer->writeUInt32($this->timestamp);
         $buffer->writeHex($this->senderPublicKey);
 
-        if (isset($this->recipientId)) {
+        $skipRecipientId = $this->type === Types::SECOND_SIGNATURE_REGISTRATION || $this->type === Types::MULTI_SIGNATURE_REGISTRATION;
+        if (isset($this->recipientId) && !$skipRecipientId) {
             $buffer->writeHex(Base58::decodeCheck($this->recipientId)->getHex());
         } else {
             $buffer->fill(21);

tests/Concerns/Deserialize.php

@@ -27,6 +27,7 @@ protected function assertDeserialized(array $expected, array $keys, int $network
         $this->assertSame($network, $actual->network);
         $this->assertSame($expected['serialized'], Serializer::new($actual->toArray())->serialize()->getHex());
         $this->assertSameTransactions($expected, $actual, $keys);
+        $this->assertTrue($actual->verify());
 
         return $actual;
     }