fix(tests): undefined is returned instead of an empty arraybuffer

Author: azaleacolburn

fission/src/mirabuf/MirabufLoader.ts

@@ -386,7 +386,7 @@ class MirabufCachingService {
 
         try {
             // Get buffer from hashMap. If not in hashMap, check OPFS. Otherwise, buff is undefined
-            const getOPFSBuffer = async () => {
+            const getOPFSBuffer = async (): Promise<ArrayBuffer | undefined> => {
                 const dirHandle = dirHandleMap[miraType]
                 if (!canOPFS) return
 
@@ -396,7 +396,7 @@ class MirabufCachingService {
                 return await fileHandle.getFile().then(x => x.arrayBuffer())
             }
 
-            const buff = ((cache[id]?.buffer ?? new Uint8Array()).buffer as ArrayBuffer) ?? (await getOPFSBuffer())
+            const buff = (cache[id]?.buffer?.buffer as ArrayBuffer | undefined) ?? (await getOPFSBuffer())
             if (!buff) {
                 console.error(`Failed to find arrayBuffer for id: ${id}`)
                 return undefined

fission/src/mirabuf/MirabufParser.ts

@@ -93,7 +93,7 @@ class MirabufParser {
         this._globalTransforms = new Map()
         this._gamePieces = undefined
         this._isGamePiece = isGamePiece
-        if (assembly.transform && isGamePiece)
+        if (isGamePiece && assembly.transform)
             this._gamePieceTransform = convertMirabufTransformToThreeMatrix(assembly.transform)
 
         progressHandle?.update("Parsing assembly...", 0.3)

fission/src/test/MirabufParser.test.ts

@@ -8,7 +8,10 @@ describe("Mirabuf Parser Tests", () => {
         const spikeMira = await MirabufCachingService.cacheRemote(
             "/api/mira/robots/Dozer_v9.mira",
             MiraType.ROBOT
-        ).then(x => MirabufCachingService.get(x!.id, MiraType.ROBOT))
+        ).then(x => {
+            expect(x).toBeDefined()
+            return MirabufCachingService.get(x!.id, MiraType.ROBOT)
+        })
 
         const t = new MirabufParser(spikeMira!)
         const rn = [...t.rigidNodes.values()]

fission/src/test/physics/PhysicsSystemRobotSpawning.test.ts

@@ -11,6 +11,7 @@ describe("Mirabuf Physics Loading", () => {
                 return MirabufCachingService.get(x!.id, MiraType.ROBOT)
             }
         )
+
         const parser = new MirabufParser(assembly!)
         const physSystem = new PhysicsSystem()
         const mapping = physSystem.createBodiesFromParser(parser, new LayerReserve())