Skip to content

Commit 5e852db

Browse files
authored
Forms: fix React error with key for listed files (#44263)
1 parent e9e7f3b commit 5e852db

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: fixed
3+
4+
Forms: fix React error with key for listed files.

projects/packages/forms/src/dashboard/inbox/response.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const PreviewFile = ( { file, isLoading, onImageLoaded } ) => {
6060
);
6161
};
6262

63-
const FileField = ( { file, onClick, key } ) => {
63+
const FileField = ( { file, onClick } ) => {
6464
const fileExtension = file.name.split( '.' ).pop().toLowerCase();
6565
const fileType = file.type.split( '/' )[ 0 ];
6666

@@ -96,7 +96,7 @@ const FileField = ( { file, onClick, key } ) => {
9696
const iconType = extensionMap[ fileExtension ] || iconMap[ fileType ] || 'txt';
9797
const iconClass = clsx( 'file-field__icon', 'icon-' + iconType );
9898
return (
99-
<div key={ key } className="file-field__item">
99+
<div className="file-field__item">
100100
<div className="file-field__info">
101101
<div className={ iconClass }></div>
102102
<div className="file-field__name">
@@ -174,12 +174,16 @@ const InboxResponse = ( { response, loading, onModalStateChange } ) => {
174174
return (
175175
<div className="file-field">
176176
{ value.files?.length
177-
? value.files.map( ( file, index ) => {
177+
? value.files.map( file => {
178178
if ( ! file || ! file.name ) {
179179
return null;
180180
}
181181
return (
182-
<FileField file={ file } onClick={ handleFilePreview( file ) } key={ index } />
182+
<FileField
183+
file={ file }
184+
onClick={ handleFilePreview( file ) }
185+
key={ file.file_id }
186+
/>
183187
);
184188
} )
185189
: '-' }

0 commit comments

Comments
 (0)