-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: Fix checkbox checkmark border color for better contrast #46129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
| .contact-form .is-style-list input.consent:checked::after { | ||
| // consent checkboxes are sometimes scaled. | ||
| // Keep it centered and with same angle. | ||
| transform: rotate(30deg) scale(0.7) translate(-40%, -15%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be different from the current one.
translate(-50%, -60%) rotate(40deg); is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be different from the current one.
Which current one?
|
This PR works well but it also change the style of the checkbox to appear differently. The previous version is more as designed. cc @ilonagl and @ederrengifo for the feedback here. |
…me as text, since background is set to be that of input backgrounds it should always hold a good contrast (merely mocking text input background/font color relation)
f24a4f6 to
6f82113
Compare
Would be nice to do a full revisit to what's the expected design on each case, with an atomic approach to:
And how those relate to other inputs (including buttons) styling. Once we establish a pattern/strategy/approach/system, we should be able to find a more common ground for all those, not to mention not having to ask every single time "how should this look on frontend?". Then put it to the test against multiple themes and see how we can allow for consistent overrides from the themes. We shouldn't change the entire style so to fit the need of a single theme, IMHO. In the meantime, this PR aims to settle for what's the most wide/safe solution in terms of legibility, but might not be enough for the desired effect/design. |
|
@ederrengifo remember this work on unifying checkboxes that you some months ago? 😄 Do you want to take a look at this? If you're busy, no worries, I can do that too. |


Part of FORMS-437
Proposed changes:
Other information:
Jetpack product discussion
p1764251172431619-slack-C052XEUUBL4
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Before / After: