Skip to content

Conversation

@t-wright
Copy link

@t-wright t-wright commented Nov 28, 2025

Proposed changes:

  • Introduces a filter jetpack.externalMedia.extraMediaSources which allows adding additional media sources to the media button sources dropdown.
  • Checks whether the ai-featured-image-generator extension is available before rendering the Generate with AI button as a featured image media button source.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Context for this change can be found in Linear FORNO-74

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Run bin/jetpack-downloader test jetpack forno-74/add/extra-media-sources-filter on your sandbox
  • Open the post editor
  • Add an image block
  • Click on the Set featured image button and verify that the existing options are available
  • Set the ai-featured-image-generator feature to unavailable window.Jetpack_Editor_Initial_State.available_blocks['ai-featured-image-generator'].available = false;
  • Click on the Set featured image button and verify the Generate with AI option is no longer shown
  • Add the filter. E.g.
wp_add_inline_script(
	'wp-blocks',
	'wp.hooks.addFilter( "jetpack.externalMedia.extraMediaSources", "myplugin", ( value, args ) => {
		return [{
			id: "myplugin-extra-source",
			label: "My Source",
			icon: "admin-site",
			onClick: () => {
				const image = { id: 123, url: "https://example.com/image.jpg" }; // update this with an actual image attachment
				args.onSelect( args.multiple ? [ image ] : image );
			}
		}];
	} );'
);
  • Add an image block and click Select Image
  • Verify My Source appears in the list and clicking it adds the image to the block

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forno-74/add/extra-media-sources-filter branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forno-74/add/extra-media-sources-filter

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 28, 2025
@t-wright t-wright added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Nov 28, 2025
@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@t-wright t-wright marked this pull request as ready for review November 28, 2025 02:45
@t-wright t-wright added the [Status] Needs Review This PR is ready for review. label Nov 28, 2025
@t-wright t-wright requested review from a team, ariskataoka and saroshaga November 28, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] External Media [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants