-
Notifications
You must be signed in to change notification settings - Fork 843
FORNO-74: External Media – Add filter for including additional sources in media sources dropdown #46131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Proposed changes:
jetpack.externalMedia.extraMediaSourceswhich allows adding additional media sources to the media button sources dropdown.ai-featured-image-generatorextension is available before rendering theGenerate with AIbutton as a featured image media button source.Other information:
Jetpack product discussion
Context for this change can be found in Linear FORNO-74
Does this pull request change what data or activity we track or use?
No
Testing instructions:
bin/jetpack-downloader test jetpack forno-74/add/extra-media-sources-filteron your sandboxSet featured imagebutton and verify that the existing options are availableai-featured-image-generatorfeature to unavailablewindow.Jetpack_Editor_Initial_State.available_blocks['ai-featured-image-generator'].available = false;Set featured imagebutton and verify theGenerate with AIoption is no longer shownSelect ImageMy Sourceappears in the list and clicking it adds the image to the block