-
Notifications
You must be signed in to change notification settings - Fork 843
Newsletter: Implement comprehensive settings UI with DataForm #46136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
This is the initial, very rough work-in-progress of bringing the newsletter settings UI into wp-admin using DataForms. It's mostly untested, needs styling etc.
| Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
Fixes DOTCOM-15286
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No changes to data tracking or activity tracking.
Testing instructions:
Prerequisites:
isSubscriptionSiteEditSupported)Test Steps: