Affirm&Afterpay: refactor subscription product detection. (#6605)

Co-authored-by: Miguel Gasca <[email protected]>

Author: kalessil

changelog/dev-affirm-afterpay-subscription-detection-enahnce

@@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Affirm&Afterpay: refactor subscription products detection by using existing subs API

includes/class-wc-payments.php

@@ -1660,9 +1660,8 @@ public static function load_stripe_bnpl_site_messaging() {
 			$is_subscription           = false;
 			$are_subscriptions_enabled = class_exists( 'WC_Subscriptions' ) || class_exists( 'WC_Subscriptions_Core_Plugin' );
 			if ( $are_subscriptions_enabled ) {
-					// The subscription identification shall be aligned with WC_Subscriptions_Product::is_subscription.
 					global $product;
-					$is_subscription = $product && $product->is_type( [ 'subscription', 'subscription_variation', 'variable-subscription' ] );
+					$is_subscription = $product && WC_Subscriptions_Product::is_subscription( $product );
 			}
 
 			if ( ! $is_subscription ) {

psalm-baseline.xml

@@ -31,6 +31,11 @@
       <code>WC_Subscriptions_Product</code>
     </UndefinedClass>
   </file>
+  <file src="includes/class-wc-payments.php">
+    <UndefinedClass occurrences="1">
+      <code>WC_Subscriptions_Product</code>
+    </UndefinedClass>
+  </file>
   <file src="includes/multi-currency/Compatibility/WooCommerceProductAddOns.php">
     <UndefinedClass occurrences="2">
       <code>\WC_Product_Addons_Helper</code>