chore: Leverage semantic model when looking for documents (#157)

Author: Mielek

src/Compiling/Program.cs

@@ -20,13 +20,13 @@
     await Console.Out.WriteLineAsync("Project mode");
     var compiler = serviceProvider.GetRequiredService<ProjectCompiler>();
     var result = await compiler.Compile(options.ToProjectCompilerOptions());
-    return result.DocumentResults.Sum(r => r.Diagnostics.Count);
+    return result.DocumentResults.Sum(r => r.Errors.Length);
 }
 else
 {
     await Console.Error.WriteLineAsync(
         "Directory mode is deprecated. Please use project mode by pointing source parameter to .csproj file or to folder with one .csproj file.");
     var compiler = serviceProvider.GetRequiredService<DirectoryCompiler>();
     var result = await compiler.Compile(options.ToDirectoryCompilerOptions());
-    return result.DocumentResults.Sum(r => r.Diagnostics.Count);
+    return result.DocumentResults.Sum(r => r.Errors.Length);
 }

src/Core/Compiling/CompilerUtils.cs

@@ -4,6 +4,7 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Xml.Linq;
 
+using Microsoft.Azure.ApiManagement.PolicyToolkit.Authoring;
 using Microsoft.Azure.ApiManagement.PolicyToolkit.Compiling.Diagnostics;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;

src/Core/Compiling/DirectoryCompiler.cs

@@ -35,20 +35,20 @@ public Task<DirectoryCompilerResult> Compile(DirectoryCompilerOptions options)
                 syntaxTrees: [syntax],
                 references: References);
 
-            var documents = syntax.GetRoot()
-                .GetDocumentAttributedClasses();
+            var semantics = compilation.GetSemanticModel(syntax);
+            var documents = syntax.GetRoot().GetDocumentAttributedClasses(semantics);
 
             foreach (var document in documents)
             {
                 IDocumentCompilationResult documentResult = compiler.Compile(compilation, document);
                 result.DocumentResults.Add(documentResult);
 
-                foreach (var error in documentResult.Diagnostics)
+                foreach (var error in documentResult.Errors)
                 {
                     Console.Error.WriteLine(error.ToString());
                 }
 
-                var policyFileName = document.ExtractDocumentFileName();
+                var policyFileName = document.ExtractDocumentFileName(semantics);
                 var targetFile = FileUtils.WriteToFile(new FileUtils.Data()
                 {
                     Element = documentResult.Document,

src/Core/Compiling/DocumentCompilationContext.cs

@@ -1,29 +1,32 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using System.Collections.Immutable;
 using System.Xml.Linq;
 
 using Microsoft.CodeAnalysis;
 
 namespace Microsoft.Azure.ApiManagement.PolicyToolkit.Compiling;
 
-public class DocumentCompilationContext(Compilation compilation, SyntaxNode syntaxRoot, XElement rootElement)
+public class DocumentCompilationContext(Compilation compilation, SyntaxNode syntaxRoot, XElement currentElement)
     : IDocumentCompilationContext, IDocumentCompilationResult
 {
-    private readonly IList<Diagnostic> _diagnostics = new List<Diagnostic>();
-
-    public DocumentCompilationContext(DocumentCompilationContext parent, XElement rootElement) : this(
-        parent.Compilation, parent.SyntaxRoot, rootElement)
+    public DocumentCompilationContext(IDocumentCompilationContext parent, XElement currentElement)
+        : this(parent.Compilation, parent.SyntaxRoot, currentElement)
     {
-        _diagnostics = parent._diagnostics;
+        RootElement = parent.RootElement;
+        Diagnostics = parent.Diagnostics;
     }
 
-    public void AddPolicy(XNode element) => rootElement.Add(element);
-    public void Report(Diagnostic diagnostic) => _diagnostics.Add(diagnostic);
+    public void AddPolicy(XNode element) => CurrentElement.Add(element);
+    public void Report(Diagnostic diagnostic) => Diagnostics.Add(diagnostic);
 
     public Compilation Compilation { get; } = compilation;
     public SyntaxNode SyntaxRoot { get; } = syntaxRoot;
+    public XElement RootElement { get; } = currentElement;
+    public XElement CurrentElement { get; } = currentElement;
+    public IList<Diagnostic> Diagnostics { get; } = new List<Diagnostic>();
 
-    public XElement Document => rootElement;
-    public IReadOnlyList<Diagnostic> Diagnostics => _diagnostics.AsReadOnly();
+    public XElement Document => CurrentElement;
+    public ImmutableArray<Diagnostic> Errors => [..Diagnostics];
 }

src/Core/Compiling/IDocumentCompilationContext.cs

@@ -14,4 +14,8 @@ public interface IDocumentCompilationContext
 
     Compilation Compilation { get; }
     SyntaxNode SyntaxRoot { get; }
+    IList<Diagnostic> Diagnostics { get; }
+
+    XElement RootElement { get; }
+    XElement CurrentElement { get; }
 }

src/Core/Compiling/IDocumentCompilationResult.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using System.Collections.Immutable;
 using System.Xml.Linq;
 
 using Microsoft.CodeAnalysis;
@@ -10,5 +11,5 @@ namespace Microsoft.Azure.ApiManagement.PolicyToolkit.Compiling;
 public interface IDocumentCompilationResult
 {
     XElement Document { get; }
-    IReadOnlyList<Diagnostic> Diagnostics { get; }
+    ImmutableArray<Diagnostic> Errors { get; }
 }

src/Core/Compiling/Policy/LimitConcurrencyCompiler.cs

@@ -85,7 +85,7 @@ public void Handle(IDocumentCompilationContext context, InvocationExpressionSynt
             return;
         }
 
-        SubDocumentCompilationContext subContext = new(context, element);
+        var subContext = new DocumentCompilationContext(context, element);
         _blockCompiler.Value.Compile(subContext, lambda.Block);
 
         context.AddPolicy(element);

src/Core/Compiling/Policy/RetryCompiler.cs

@@ -99,7 +99,7 @@ public void Handle(IDocumentCompilationContext context, InvocationExpressionSynt
         element.AddAttribute(config, nameof(RetryConfig.Delta), "delta");
         element.AddAttribute(config, nameof(RetryConfig.FirstFastRetry), "first-fast-retry");
 
-        SubDocumentCompilationContext subContext = new(context, element);
+        var subContext = new DocumentCompilationContext(context, element);
         _blockCompiler.Value.Compile(subContext, lambda.Block);
 
         context.AddPolicy(element);

src/Core/Compiling/Policy/WaitCompiler.cs

@@ -59,7 +59,7 @@ public void Handle(IDocumentCompilationContext context, InvocationExpressionSynt
             element.Add(new XAttribute("for", value));
         }
 
-        SubDocumentCompilationContext subContext = new(context, element);
+        var subContext = new DocumentCompilationContext(context, element);
         _blockCompiler.Value.Compile(subContext, lambda.Block);
 
         context.AddPolicy(element);

src/Core/Compiling/ProjectCompiler.cs

@@ -53,18 +53,19 @@ public async Task<ProjectCompilerResult> Compile(ProjectCompilerOptions options,
         {
             await Console.Out.WriteLineAsync($"File '{syntaxTree.FilePath}' processing");
             var root = await syntaxTree.GetRootAsync(cancellationToken);
-            var documents = root.GetDocumentAttributedClasses();
+            var semantics = compilation.GetSemanticModel(syntaxTree);
+            var documents = root.GetDocumentAttributedClasses(semantics);
             foreach (var document in documents)
             {
                 var documentResult = documentCompiler.Compile(compilation, document);
                 result.DocumentResults.Add(documentResult);
 
-                foreach (var error in documentResult.Diagnostics)
+                foreach (var error in documentResult.Errors)
                 {
                     await Console.Error.WriteLineAsync(error.ToString());
                 }
 
-                var policyFileName = document.ExtractDocumentFileName();
+                var policyFileName = document.ExtractDocumentFileName(semantics);
                 var targetFile = FileUtils.WriteToFile(new FileUtils.Data()
                 {
                     Element = documentResult.Document,