Skip to content

Conversation

@khushishah513
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 11, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp function sub group containerapp function added

@azure-client-tools-bot-prd
Copy link

Hi @khushishah513,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 11, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @khushishah513

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b4 in src/containerapp/setup.py

Notes

@khushishah513 khushishah513 changed the title [Container App] az containerapp functions: Add list and show commands for container app functions [Container App] az containerapp function: Add list and show commands for container app functions Sep 13, 2025
[Containerapp] `az containerapp function`: Add function key management commands
===============
upcoming
++++++
* 'az containerapp function show/list': New command group to list and show functions in container apps.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review command from Nitesh/Deep


helps['containerapp function'] = """
type: group
short-summary: Commands to view functions in a container app.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short-summary: Commands to view functions in a container app.
short-summary: Commands to view functions in an Azure Functions on Azure Container Apps.

Let's be explicit here, as this command is only applicable for Functions on ACA v2, and not for direct ACA customer using functions image without kind=functionapp.


helps['containerapp function list'] = """
type: command
short-summary: List all functions in a container app or a specific revision. (pass --revisionName parameter)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short-summary: List all functions in a container app or a specific revision. (pass --revisionName parameter)
short-summary: List all functions in an Azure Functions on Azure Container Apps.

Current summary seems to convey that the --revisionName parameter is mandatory, which is not true. Let's remove revision-specific help command, similar to other commands like az containerapp replica count.

with self.argument_context('containerapp function list') as c:
c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None)
c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.")
c.argument('revision_name', options_list=['--revision-name', '-r'], help="The name of the revision to list functions from. It is required if container app is running in multiple active revision mode.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter should just be --revision, following convention from other commands

type: command
short-summary: List all functions in a container app or a specific revision. (pass --revisionName parameter)
long-summary: |
revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode)
--revision is required if the
Suggested change
revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode)
--revision is required only if the app is not in single revision mode.

We have multiple and labelled revision mode, so this statement will be simpler.

az containerapp function list -n my-containerapp -g MyResourceGroup
- name: List all functions for a specific revision
text: |
az containerapp function list -n my-containerapp -g MyResourceGroup --revision-name MyRevision

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
az containerapp function list -n my-containerapp -g MyResourceGroup --revision-name MyRevision
az containerapp function list -n MyContainerApp -g MyResourceGroup --revision MyRevision


helps['containerapp function show'] = """
type: command
short-summary: Show details of a specific function in a container app or a specific revision within app. (pass --revisionName parameter)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short-summary: Show details of a specific function in a container app or a specific revision within app. (pass --revisionName parameter)
short-summary: Get details of a function in an Azure Functions on Azure Container Apps.

Comment on lines +206 to +207
revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode)
Run to check activerevisionmode: az containerapp show -n my-containerapp -g MyResourceGroup --query properties.configuration.activeRevisionsMode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment from list command

with self.argument_context('containerapp function list') as c:
c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None)
c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.")
c.argument('revision_name', options_list=['--revision-name', '-r'], help="The name of the revision to list functions from. It is required if container app is running in multiple active revision mode.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


with self.argument_context('containerapp function list') as c:
c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None)
c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.")
c.argument('name', options_list=['--name', '-n'], help="The name of the Azure Functions on Azure Container Apps.")



class ContainerAppFunctionsPreviewClient():
api_version = PREVIEW_API_VERSION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we update PREVIEW_API_VERSION to the latest unreleased one? Add TODO for tracking, if not done.

@khushishah513 khushishah513 deleted the functionaca-getlist branch September 26, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants