-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Container App] az containerapp function: Add list and show commands for container app functions
#9155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp function | sub group containerapp function added |
|
Hi @khushishah513, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: containerapp
Notes
|
az containerapp functions: Add list and show commands for container app functionsaz containerapp function: Add list and show commands for container app functions
[Containerapp] `az containerapp function`: Add function key management commands
| =============== | ||
| upcoming | ||
| ++++++ | ||
| * 'az containerapp function show/list': New command group to list and show functions in container apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review command from Nitesh/Deep
|
|
||
| helps['containerapp function'] = """ | ||
| type: group | ||
| short-summary: Commands to view functions in a container app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| short-summary: Commands to view functions in a container app. | |
| short-summary: Commands to view functions in an Azure Functions on Azure Container Apps. |
Let's be explicit here, as this command is only applicable for Functions on ACA v2, and not for direct ACA customer using functions image without kind=functionapp.
|
|
||
| helps['containerapp function list'] = """ | ||
| type: command | ||
| short-summary: List all functions in a container app or a specific revision. (pass --revisionName parameter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| short-summary: List all functions in a container app or a specific revision. (pass --revisionName parameter) | |
| short-summary: List all functions in an Azure Functions on Azure Container Apps. |
Current summary seems to convey that the --revisionName parameter is mandatory, which is not true. Let's remove revision-specific help command, similar to other commands like az containerapp replica count.
| with self.argument_context('containerapp function list') as c: | ||
| c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None) | ||
| c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.") | ||
| c.argument('revision_name', options_list=['--revision-name', '-r'], help="The name of the revision to list functions from. It is required if container app is running in multiple active revision mode.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter should just be --revision, following convention from other commands
| type: command | ||
| short-summary: List all functions in a container app or a specific revision. (pass --revisionName parameter) | ||
| long-summary: | | ||
| revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode) | |
| --revision is required if the |
| revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode) | |
| --revision is required only if the app is not in single revision mode. |
We have multiple and labelled revision mode, so this statement will be simpler.
| az containerapp function list -n my-containerapp -g MyResourceGroup | ||
| - name: List all functions for a specific revision | ||
| text: | | ||
| az containerapp function list -n my-containerapp -g MyResourceGroup --revision-name MyRevision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| az containerapp function list -n my-containerapp -g MyResourceGroup --revision-name MyRevision | |
| az containerapp function list -n MyContainerApp -g MyResourceGroup --revision MyRevision |
|
|
||
| helps['containerapp function show'] = """ | ||
| type: command | ||
| short-summary: Show details of a specific function in a container app or a specific revision within app. (pass --revisionName parameter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| short-summary: Show details of a specific function in a container app or a specific revision within app. (pass --revisionName parameter) | |
| short-summary: Get details of a function in an Azure Functions on Azure Container Apps. |
| revisionName is required only if Container App active Revision Mode is setup in Multiple Revision Mode. (Default: Single Revision Mode) | ||
| Run to check activerevisionmode: az containerapp show -n my-containerapp -g MyResourceGroup --query properties.configuration.activeRevisionsMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment from list command
| with self.argument_context('containerapp function list') as c: | ||
| c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None) | ||
| c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.") | ||
| c.argument('revision_name', options_list=['--revision-name', '-r'], help="The name of the revision to list functions from. It is required if container app is running in multiple active revision mode.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| with self.argument_context('containerapp function list') as c: | ||
| c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None) | ||
| c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| c.argument('name', options_list=['--name', '-n'], help="The name of the Container App.") | |
| c.argument('name', options_list=['--name', '-n'], help="The name of the Azure Functions on Azure Container Apps.") |
|
|
||
|
|
||
| class ContainerAppFunctionsPreviewClient(): | ||
| api_version = PREVIEW_API_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we update PREVIEW_API_VERSION to the latest unreleased one? Add TODO for tracking, if not done.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.