New-AzResourceGroupDeployment should not execute whatif when ConfirmPreference== ConfirmImpact.None

[henriblMSFT]

Description

Setting ConfirmImpact.None has the same behavior as setting ConfirmImpact.Low when executing the New-AzResourceGroupDeployment and executes the WhatIf behavior

Steps to reproduce

$ConfirmPreference = "None"
New-AzResourceGroupDeployment [...]

The bug is in ShouldProcessGivenCurrentConfirmFlagAndPreference

        private bool ShouldProcessGivenCurrentConfirmFlagAndPreference()
        {
            if (this.MyInvocation.BoundParameters.GetOrNull("Confirm") is SwitchParameter confirmFlag)
            {
                return confirmFlag.IsPresent;
            }

            if (this.SessionState == null)
            {
                return false;
            }

            var confirmPreference = (ConfirmImpact)this.SessionState.PSVariable.GetValue("ConfirmPreference");

            return this.ConfirmImpact >= confirmPreference;
        }

specifically

 return this.ConfirmImpact >= confirmPreference;

should be

return confirmPreference != ConfirmImpact.None && this.ConfirmImpact >= confirmPreference;

Module versions

5.4.0

workaround

if($ConfirmPreference -eq "None") {
  New-AzResourceGroupDeployment [...] -Confirm:$false
} else {
  New-AzResourceGroupDeployment [...]
}

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @armleads-azure.

Issue Details

---

Description

Setting ConfirmImpact.None has the same behavior as setting ConfirmImpact.Low when executing the New-AzResourceGroupDeployment and executes the WhatIf behavior

Steps to reproduce

$ConfirmPreference = "None"
New-AzResourceGroupDeployment [...]

The bug is in ShouldProcessGivenCurrentConfirmFlagAndPreference

        private bool ShouldProcessGivenCurrentConfirmFlagAndPreference()
        {
            if (this.MyInvocation.BoundParameters.GetOrNull("Confirm") is SwitchParameter confirmFlag)
            {
                return confirmFlag.IsPresent;
            }

            if (this.SessionState == null)
            {
                return false;
            }

            var confirmPreference = (ConfirmImpact)this.SessionState.PSVariable.GetValue("ConfirmPreference");

            return this.ConfirmImpact >= confirmPreference;
        }

specifically

 return this.ConfirmImpact >= confirmPreference;

should be

return confirmPreference != ConfirmImpact.None && this.ConfirmImpact >= confirmPreference;

Module versions

5.4.0

workaround

if($ConfirmPreference -eq "None") {
  New-AzResourceGroupDeployment [...] -Confirm:$false
} else {
  New-AzResourceGroupDeployment [...]
}

Author:	henriblMSFT
Assignees:	-
Labels:	ARM, Service Attention, customer-reported, question
Milestone:	-

[SaurabhSharma-MSFT]

@henriblMSFT Apologies for the delayed response. I see that this issue is opened long time ago and no further activity had taken place. So wanted to check if you are still looking for assistance on this query? Please let us know .

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

[henriblMSFT]

The bug does not appear to be fixed. Do you need any additional information from me here?