Skip to content

Commit 0024a0e

Browse files
committed
- add "callbackUrlDomain" option to Users.getAuthorizationUrlLink method
1 parent c88e5a3 commit 0024a0e

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

backendless.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ declare module Backendless {
362362

363363
function disableUser(userId: string): Promise<void>;
364364

365-
function getAuthorizationUrlLink(providerCode: string, fieldsMapping?: object, scope?: string, redirect?: boolean, redirectAfterLoginUrl?: string): Promise<string>;
365+
function getAuthorizationUrlLink(providerCode: string, fieldsMapping?: object, scope?: string, redirect?: boolean, redirectAfterLoginUrl?: string, callbackUrlDomain?: string): Promise<string>;
366366
}
367367

368368
/**

src/users/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,10 +307,10 @@ export default class Users {
307307
})
308308
}
309309

310-
getAuthorizationUrlLink(providerCode, fieldsMapping, scope, redirect, redirectAfterLoginUrl) {
310+
getAuthorizationUrlLink(providerCode, fieldsMapping, scope, redirect, redirectAfterLoginUrl, callbackUrlDomain) {
311311
return this.app.request.post({
312312
url : this.app.urls.userAuthorizationURL(providerCode),
313-
data: { fieldsMapping, permissions: scope, redirect, redirectAfterLoginUrl }
313+
data: { fieldsMapping, permissions: scope, redirect, redirectAfterLoginUrl, callbackUrlDomain }
314314
})
315315
}
316316

test/tsd.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,10 +920,12 @@ function testUserService() {
920920

921921
promiseVoid = Backendless.UserService.disableUser(userId);
922922

923+
promiseString = Backendless.UserService.getAuthorizationUrlLink('google', {email: 'userEmail'}, 'email;photo', false, 'https://foo', 'foo.bar');
923924
promiseString = Backendless.UserService.getAuthorizationUrlLink('google', {email: 'userEmail'}, 'email;photo', false);
924925
promiseString = Backendless.UserService.getAuthorizationUrlLink('google', null, null, true);
925926
promiseString = Backendless.UserService.getAuthorizationUrlLink('google');
926927
promiseString = Backendless.UserService.getAuthorizationUrlLink('google', null, null, false, 'url');
928+
promiseString = Backendless.UserService.getAuthorizationUrlLink('google', null, null, false, null, 'foo.bar');
927929

928930
promiseUsersList = Backendless.UserService.findByRole(roleName);
929931
promiseUsersList = Backendless.UserService.findByRole(roleName, true);

test/unit/specs/users/oauth.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,11 @@ describe('<Users> OAuth Login', function() {
134134
describe('with guestUser argument', () => {
135135
const guestObjectId = Utils.objectId()
136136
const guestUserToken = Utils.uid()
137-
const guestUser = new Backendless.User({ objectId: guestObjectId, 'user-token': guestUserToken, userStatus: 'GUEST' })
137+
const guestUser = new Backendless.User({
138+
objectId : guestObjectId,
139+
'user-token': guestUserToken,
140+
userStatus : 'GUEST'
141+
})
138142

139143
it('login with guestUser', async () => {
140144
const objectId = Utils.objectId()
@@ -256,10 +260,11 @@ describe('<Users> OAuth Login', function() {
256260
const scope = 'email;photo'
257261
const redirect = false
258262
const redirectAfterLoginUrl = 'https://authorization-redirect-url-example.com'
263+
const callbackUrlDomain = 'foo.bar'
259264

260265
const req = prepareMockRequest(url)
261266

262-
const authorizationURL = await Backendless.UserService.getAuthorizationUrlLink(provideCode, fieldsMapping, scope, redirect, redirectAfterLoginUrl)
267+
const authorizationURL = await Backendless.UserService.getAuthorizationUrlLink(provideCode, fieldsMapping, scope, redirect, redirectAfterLoginUrl, callbackUrlDomain)
263268

264269
expect(req).to.deep.include({
265270
method : 'POST',
@@ -270,6 +275,7 @@ describe('<Users> OAuth Login', function() {
270275
permissions: scope,
271276
redirect,
272277
redirectAfterLoginUrl,
278+
callbackUrlDomain,
273279
}
274280
})
275281

0 commit comments

Comments
 (0)