- fix unhandled error when flushing logs

Author: Valodya

src/index.js

@@ -278,7 +278,11 @@ class Backendless {
       return this.domain + this.apiURI
     }
 
-    return [this.serverURL, this.appId, this.apiKey].join('/')
+    if (this.appId && this.apiKey) {
+      return [this.serverURL, this.appId, this.apiKey].join('/')
+    }
+
+    return null
   }
 
   set appPath(appPath) {

src/logging/index.js

@@ -78,17 +78,20 @@ export default class Logging {
 
       this.messages = []
 
-      this.flushRequest = this.app.request
-        .put({
-          url : this.app.urls.logging(),
-          data: messages
-        })
-        .catch(error => {
-          this.messages = [...messages, ...this.messages]
-
-          this.checkMessagesLimit()
-
-          throw error
+      this.flushRequest = Promise.resolve()
+        .then(() => {
+          return this.app.request
+            .put({
+              url : this.app.urls.logging(),
+              data: messages
+            })
+            .catch(error => {
+              this.messages = [...messages, ...this.messages]
+
+              this.checkMessagesLimit()
+
+              throw error
+            })
         })
         .finally(() => delete this.flushRequest)
     }
@@ -116,6 +119,10 @@ export default class Logging {
     this.checkMessagesLenTimer = setTimeout(() => {
       if (this.messages.length >= this.numOfMessages) {
         this.flush()
+          .catch(error => {
+            // eslint-disable-next-line no-console
+            console.error('Could not flush log messages immediately: ', error)
+          })
       } else {
         this.startFlushInterval()
       }
@@ -130,7 +137,13 @@ export default class Logging {
 
   startFlushInterval() {
     if (!this.flushInterval) {
-      this.flushInterval = setTimeout(() => this.flush(), this.timeFrequency * 1000)
+      this.flushInterval = setTimeout(() => {
+        this.flush()
+          .catch(error => {
+            // eslint-disable-next-line no-console
+            console.error('Could not flush log messages with timer: ', error)
+          })
+      }, this.timeFrequency * 1000)
     }
   }
 

src/urls.js

@@ -4,6 +4,13 @@ export default class Urls {
   }
 
   root() {
+    if (!this.app.appPath) {
+      throw new Error(
+        'Backendless API is not configured, make sure you run Backendless.initApp(...) ' +
+        'before the operation'
+      )
+    }
+
     return this.app.appPath
   }
 

test/unit/specs/logging.js

@@ -213,6 +213,8 @@ describe('<Logging>', function() {
   })
 
   it('doesnt throw an error if the message is not a string', async () => {
+    prepareMockRequest({})
+
     async function check(method) {
       expect(() => logger[method](0)).to.not.throw()
       expect(() => logger[method](123)).to.not.throw()
@@ -231,6 +233,8 @@ describe('<Logging>', function() {
     await check('error')
     await check('fatal')
     await check('trace')
+
+    await Backendless.Logging.flush()
   })
 
   it('converts non-string values to strings', async () => {
@@ -324,8 +328,16 @@ describe('<Logging>', function() {
   })
 
   it('should try to send next time if it was failed', async () => {
+    // eslint-disable-next-line no-console
+    const _nativeConsoleError = console.error
+
+    // eslint-disable-next-line no-console
+    const spyConsoleError = console.error = chai.spy()
+
+    const error = new Error('Test Error')
+
     const req1 = prepareMockRequest(() => {
-      throw new Error('Test Error')
+      throw error
     })
 
     const req2 = prepareMockRequest()
@@ -357,14 +369,30 @@ describe('<Logging>', function() {
       { 'log-level': 'DEBUG', 'logger': loggerName, 'message': 'debug message - 2', timestamp: req1.body[1].timestamp },
       { 'log-level': 'DEBUG', 'logger': loggerName, 'message': 'debug message - 3', timestamp: req2.body[2].timestamp }
     ])
+
+    expect(spyConsoleError).to.have.been.called.exactly(1)
+
+    expect(spyConsoleError).on.nth(1).be.called.with('Could not flush log messages immediately: ', error)
+
+    // eslint-disable-next-line no-console
+    console.error = _nativeConsoleError
   })
 
   it('should keep messages if they were not sent #1', async () => {
+    // eslint-disable-next-line no-console
+    const _nativeConsoleError = console.error
+
+    // eslint-disable-next-line no-console
+    const spyConsoleError = console.error = chai.spy()
+
+    const error1 = new Error('Test Error1')
+    const error2 = new Error('Test Error2')
+
     const req1 = prepareMockRequest(() => {
-      throw new Error('Test Error1')
+      throw error1
     })
     const req2 = prepareMockRequest(() => {
-      throw new Error('Test Error2')
+      throw error2
     })
     const req3 = prepareMockRequest()
 
@@ -406,14 +434,31 @@ describe('<Logging>', function() {
       { 'log-level': 'DEBUG', 'logger': loggerName, 'message': 'debug message - 5', timestamp: req3.body[4].timestamp },
       { 'log-level': 'DEBUG', 'logger': loggerName, 'message': 'debug message - 6', timestamp: req3.body[5].timestamp },
     ])
+
+    expect(spyConsoleError).to.have.been.called.exactly(2)
+
+    expect(spyConsoleError).on.nth(1).be.called.with('Could not flush log messages immediately: ', error1)
+    expect(spyConsoleError).on.nth(2).be.called.with('Could not flush log messages immediately: ', error2)
+
+    // eslint-disable-next-line no-console
+    console.error = _nativeConsoleError
   })
 
   it('should keep messages if they were not sent #2', async () => {
+    // eslint-disable-next-line no-console
+    const _nativeConsoleError = console.error
+
+    // eslint-disable-next-line no-console
+    const spyConsoleError = console.error = chai.spy()
+
+    const error1 = new Error('Test Error1')
+    const error2 = new Error('Test Error2')
+
     const req1 = prepareMockRequest(() => {
-      throw new Error('Test Error1')
+      throw error1
     })
     const req2 = prepareMockRequest(() => {
-      throw new Error('Test Error2')
+      throw error2
     })
     const req3 = prepareMockRequest()
 
@@ -461,6 +506,14 @@ describe('<Logging>', function() {
       { 'log-level': 'DEBUG', 'logger': loggerName, 'message': 'debug message - 7', timestamp: req3.body[5].timestamp },
       { 'log-level': 'DEBUG', 'logger': loggerName, 'message': 'debug message - 8', timestamp: req3.body[6].timestamp },
     ])
+
+    expect(spyConsoleError).to.have.been.called.exactly(2)
+
+    expect(spyConsoleError).on.nth(1).be.called.with('Could not flush log messages immediately: ', error1)
+    expect(spyConsoleError).on.nth(2).be.called.with('Could not flush log messages immediately: ', error2)
+
+    // eslint-disable-next-line no-console
+    console.error = _nativeConsoleError
   })
 
   it('should send 100 messages by default', async () => {

test/unit/specs/rt/basic.js

@@ -201,13 +201,17 @@ describe('<RT> Basic', function() {
     const rtAppId = 'rt-app-id'
     const rtAPIKey = 'rt-api-key'
 
-    const backendlessApp = Backendless.initApp({
-      domain,
-      standalone: true,
-    })
+    let backendlessApp
 
     before(async () => {
       rtClient = await createMockRTServer(rtAppId)
+    })
+
+    beforeEach(async () => {
+      backendlessApp = Backendless.initApp({
+        domain,
+        standalone: true,
+      })
 
       backendlessApp.appInfoPromise = chai.spy(() =>
         Promise.resolve({ appId: rtAppId, apiKey: rtAPIKey, rtURL: host })