Merge pull request #22 from pywugate/dev

Replace Base.download() with Downloads.download()

Author: BoZenKhaa

.gitignore

@@ -10,4 +10,5 @@
 *.jl.cov
 
 # Dev tools
-.vscode/
+.vscode/
+Manifest_.toml

Project.toml

@@ -1,20 +1,22 @@
 name = "ReverseGeocode"
 uuid = "96b87e3f-b46e-456c-8178-0e438baab6fa"
 authors = ["Jan Mrkos <[email protected]>"]
-version = "0.5.0"
+version = "0.5.1"
 
 [deps]
 CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
+Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
 Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
 NearestNeighbors = "b8a86587-4115-5ab1-83bc-aa920d37bbce"
 ZipFile = "a5390f91-8eb1-5f08-bee0-b1d1ffed6cea"
 
 [compat]
-julia = "1"
 CSV = "0.10"
 DataFrames = "1"
 DataStructures = "0.18"
 NearestNeighbors = "0.4"
 ZipFile = "0.10"
+julia = "1"
+Downloads = "1"

src/ReverseGeocode.jl

@@ -5,7 +5,8 @@ using ZipFile,
     NearestNeighbors,
     Logging,
     DataFrames,
-    DataStructures
+    DataStructures,
+    Downloads
 
 export Geocoder, decode
 

src/geocoder.jl

@@ -177,8 +177,7 @@ function download_raw_geoname_data(;
     data_dir::String=DATA_DIR,
     geo_file::String=GEO_FILE,
 )
-
-    download("$GEO_SOURCE/$geo_file.zip", joinpath(data_dir,"$geo_file.zip"))
+    Downloads.download("$GEO_SOURCE/$geo_file.zip", joinpath(data_dir,"$geo_file.zip"))
 end
 
 """
@@ -208,7 +207,7 @@ Download and resave the country codes csv from geonames.
 Country codes are part of the package so this function does not usually need to run during install. 
 """
 function download_country_codes(;data_dir::String=DATA_DIR)
-    download("http://download.geonames.org/export/dump/countryInfo.txt", joinpath(data_dir, "countryInfo.txt"))
+    Downloads.download("http://download.geonames.org/export/dump/countryInfo.txt", joinpath(data_dir, "countryInfo.txt"))
     country_info = CSV.File(joinpath(data_dir,"countryInfo.txt"); delim="\t", header=false, select=[1,5], datarow=51)
     country_codes = Dict([(c.Column1, c.Column5) for c in country_info])
     CSV.write(joinpath(data_dir,"country_codes.csv"), country_codes, delim="\t", header=false)