Update except block for get_identifier_value

Author: Vlad0n20

osf/models/node.py

@@ -1234,16 +1234,21 @@ def set_privacy(self, permissions, auth=None, log=True, save=True, meeting_creat
                     status.push_status_message(message, kind='info', trust=False)
 
         # Update existing identifiers
-        try:
-            if self.get_identifier_value('doi'):
+        if self.get_identifier_value('doi'):
+            try:
                 update_doi_metadata_on_change(self._id)
-            elif self.is_registration:
+            except Exception:
+                logger.exception(
+                    f'Failed to update DOI metadata for {self._id} during set_privacy. '
+                )
+        elif self.is_registration:
+            try:
                 doi = self.request_identifier('doi')['doi']
                 self.set_identifier_value('doi', doi)
-        except Exception:
-            logger.exception(
-                f'Failed to create/update DOI for {self._id} during set_privacy. '
-            )
+            except Exception:
+                logger.exception(
+                    f'Failed to create DOI for registration {self._id} during set_privacy. '
+                )
 
         if log:
             action = NodeLog.MADE_PUBLIC if permissions == 'public' else NodeLog.MADE_PRIVATE

osf_tests/test_registrations.py

@@ -394,6 +394,24 @@ def test_registration_becomes_public_even_when_doi_creation_fails(self, registra
 
             mock_client.create_identifier.assert_called_once()
 
+    @mock.patch('osf.models.node.update_doi_metadata_on_change')
+    def test_registration_becomes_public_even_when_doi_metadata_update_fails(self, mock_update_doi, registration, auth):
+
+        registration.is_public = False
+        registration.set_identifier_value('doi', '10.1234/test.doi')
+        registration.save()
+
+        assert registration.get_identifier_value('doi') == '10.1234/test.doi'
+
+        mock_update_doi.side_effect = Exception('DataCite metadata update failed')
+
+        result = registration.set_privacy(Node.PUBLIC, auth=auth, log=False)
+
+        assert registration.is_public is True
+        assert result is True
+
+        mock_update_doi.assert_called_once_with(registration._id)
+
 
 class TestRegisterNodeContributors: