Cleanup tests

Author: tobias-tengler

src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Planning/GlobalObjectIdentificationTests.cs

@@ -9,7 +9,7 @@ public class GlobalObjectIdentificationTests : FusionTestBase
     #region selections on node field
 
     [Fact(Skip = "Not yet supported")]
-    public void Id_And_Typename_Selection_On_Node_Field()
+    public void Node_Field_Id_And_Typename_Selection()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -57,7 +57,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Concrete_Type_On_Node_Field_Selection_Has_Dependency()
+    public void Node_Field_Concrete_Type_Has_Dependency()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -72,12 +72,7 @@ interface Node {
 
             type Discussion implements Node @key(fields: "id") {
               id: ID!
-              viewerRating: Float!
-              product: Product
-            }
-
-            type Product @key(fields: "id") {
-              id: ID!
+              name: String
             }
             """);
 
@@ -91,9 +86,9 @@ interface Node {
               id: ID!
             }
 
-            type Product implements Node @key(fields: "id") {
+            type Discussion implements Node @key(fields: "id") {
               id: ID!
-              name: String
+              commentCount: Int
             }
             """);
 
@@ -107,11 +102,8 @@ type Product implements Node @key(fields: "id") {
             query testQuery($id: ID!) {
               node(id: $id) {
                 ... on Discussion {
-                  id
-                  viewerRating
-                  product {
-                    name
-                  }
+                  name
+                  commentCount
                 }
               }
             }
@@ -126,7 +118,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Concrete_Type_On_Node_Field_With_Dependency()
+    public void Node_Field_Concrete_Type_Selection_Has_Dependency()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -141,7 +133,12 @@ interface Node {
 
             type Discussion implements Node @key(fields: "id") {
               id: ID!
-              name: String
+              viewerRating: Float!
+              product: Product
+            }
+
+            type Product @key(fields: "id") {
+              id: ID!
             }
             """);
 
@@ -155,9 +152,9 @@ interface Node {
               id: ID!
             }
 
-            type Discussion implements Node @key(fields: "id") {
+            type Product implements Node @key(fields: "id") {
               id: ID!
-              commentCount: Int
+              name: String
             }
             """);
 
@@ -171,8 +168,11 @@ type Discussion implements Node @key(fields: "id") {
             query testQuery($id: ID!) {
               node(id: $id) {
                 ... on Discussion {
-                  name
-                  commentCount
+                  id
+                  viewerRating
+                  product {
+                    name
+                  }
                 }
               }
             }
@@ -187,7 +187,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Two_Concrete_Types_On_Node_Field_Selection_Has_Same_Dependency()
+    public void Node_Field_Two_Concrete_Types_Selections_Have_Same_Dependency()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -278,7 +278,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Two_Concrete_Types_On_Node_Field_Selection_Has_Different_Dependency()
+    public void Node_Field_Two_Concrete_Types_Selections_Have_Different_Dependencies()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -374,7 +374,7 @@ NOT SUPPORTED
     #region interface selections on node field
 
     [Fact(Skip = "Not yet supported")]
-    public void Selections_On_Interface_On_Node_Field()
+    public void Node_Field_Selections_On_Interface()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -428,7 +428,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Selections_On_Interface_And_Concrete_Type_On_Node_Field()
+    public void Node_Field_Selections_On_Interface_And_Concrete_Type()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -485,7 +485,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Selections_On_Interface_On_Node_Field_Interface_Selection_Has_Dependency()
+    public void Node_FIeld_Selections_On_Interface_And_Concrete_Type_Both_Have_Different_Dependencies()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -510,6 +510,7 @@ interface ProductList {
             type Item2 implements Node & ProductList @key(fields: "id") {
               id: ID!
               products: [Product]
+              singularProduct: Product
             }
 
             type Product implements Node @key(fields: "id") {
@@ -550,6 +551,11 @@ ... on ProductList {
                     name
                   }
                 }
+                ... on Item2 {
+                  singularProduct {
+                    name
+                  }
+                }
               }
             }
             """);
@@ -563,7 +569,7 @@ NOT SUPPORTED
     }
 
     [Fact(Skip = "Not yet supported")]
-    public void Selections_On_Interface_And_Concrete_Type_On_Node_Field_Interface_Selection_Has_Dependency()
+    public void Node_Field_Selections_On_Interface_Selection_Has_Dependency()
     {
         // arrange
         var subgraphA = new TestSubgraph(
@@ -588,7 +594,6 @@ interface ProductList {
             type Item2 implements Node & ProductList @key(fields: "id") {
               id: ID!
               products: [Product]
-              singularProduct: Product
             }
 
             type Product implements Node @key(fields: "id") {
@@ -629,11 +634,6 @@ ... on ProductList {
                     name
                   }
                 }
-                ... on Item2 {
-                  singularProduct {
-                    name
-                  }
-                }
               }
             }
             """);