Ensure that temporary tables are not accessed with database clause (#515)

* Adds missing tests from DBT for unit-tests.
* Don't create temporary tables with database.
* Don't use database to query temporary tables.

Author: koletzilla

CHANGELOG.md

@@ -1,7 +1,8 @@
 ### Release [1.9.4], 2025-XX-XX
 
 #### Bugs
-* Fix Materialized View not dropped when a model's materialization is changed from materialized_view to view ([#516](https://github.com/ClickHouse/dbt-clickhouse/pull/516))
+* Fix Materialized View not dropped when a model's materialization is changed from materialized_view to view ([#516](https://github.com/ClickHouse/dbt-clickhouse/pull/516)).
+* Ensure that temporary tables are not accessed with database clause ([#515](https://github.com/ClickHouse/dbt-clickhouse/pull/515)).
 
 
 ### Release [1.9.3], 2025-09-08
@@ -27,6 +28,7 @@
 * Check for Shared database engine in can_exchange ([#460](https://github.com/ClickHouse/dbt-clickhouse/pull/460))
 * Tests were broken because of docker compose version `2.35` and fixed in ([#468](https://github.com/ClickHouse/dbt-clickhouse/pull/468))
 
+
 ### Release [1.9.1], 2025-04-28
 
 #### Bugs

dbt/adapters/clickhouse/relation.py

@@ -43,6 +43,7 @@ class ClickHouseRelation(BaseRelation):
     quote_character: str = '`'
     can_exchange: bool = False
     can_on_cluster: bool = False
+    is_temporary: bool = False
 
     def __post_init__(self):
         if self.database != self.schema and self.database:

dbt/include/clickhouse/macros/adapters.sql

@@ -50,7 +50,9 @@
   {% call statement('get_columns', fetch_result=True) %}
     select name, type from system.columns where table = '{{ relation.identifier }}'
     {% if relation.schema %}
-      and database = '{{ relation.schema }}'
+      {% if not relation.is_temporary %}
+        and database = '{{ relation.schema }}'
+      {% endif %}
     {% else %}
       {% do exceptions.warn("Relations should always come with a defined schema. Missing schema for " ~ relation.identifier) %}
     {% endif %}

dbt/include/clickhouse/macros/materializations/table.sql

@@ -194,7 +194,7 @@
     {{ sql_header if sql_header is not none }}
 
     {% if temporary -%}
-        create temporary table {{ relation }}
+        create temporary table {{ relation.identifier }}
         engine Memory
         {{ adapter.get_model_settings(model, 'Memory') }}
         as (

dbt/include/clickhouse/macros/materializations/unit.sql

@@ -0,0 +1,34 @@
+{%- materialization unit, adapter='clickhouse' -%}
+
+  {% set relations = [] %}
+
+  {% set expected_rows = config.get('expected_rows') %}
+  {% set expected_sql = config.get('expected_sql') %}
+  {% set tested_expected_column_names = expected_rows[0].keys() if (expected_rows | length ) > 0 else get_columns_in_query(sql) %} %}
+
+  {%- set target_relation = this.incorporate(type='table') -%}
+  {%- set temp_relation = make_temp_relation(target_relation, '__dbt_tmp')-%}
+  {%- set temp_relation = temp_relation.incorporate(is_temporary=True)-%} {# file overwrite to ensure this is marked as temporary #}
+  {% do run_query(get_create_table_as_sql(True, temp_relation, get_empty_subquery_sql(sql))) %}
+  {%- set columns_in_relation = adapter.get_columns_in_relation(temp_relation) -%}
+  {%- set column_name_to_data_types = {} -%}
+  {%- for column in columns_in_relation -%}
+  {%-   do column_name_to_data_types.update({column.name|lower: column.data_type}) -%}
+  {%- endfor -%}
+
+  {% if not expected_sql %}
+  {%   set expected_sql = get_expected_sql(expected_rows, column_name_to_data_types) %}
+  {% endif %}
+  {% set unit_test_sql = get_unit_test_sql(sql, expected_sql, tested_expected_column_names) %}
+
+  {% call statement('main', fetch_result=True) -%}
+
+    {{ unit_test_sql }}
+
+  {%- endcall %}
+
+  {% do adapter.drop_relation(temp_relation) %}
+
+  {{ return({'relations': relations}) }}
+
+{%- endmaterialization -%}

tests/integration/adapter/unit_testing/test_case_insensitivity.py

@@ -0,0 +1,5 @@
+from dbt.tests.adapter.unit_testing.test_case_insensitivity import BaseUnitTestCaseInsensivity
+
+
+class TestCaseInsensivity(BaseUnitTestCaseInsensivity):
+    pass

tests/integration/adapter/unit_testing/test_invalid_input.py

@@ -0,0 +1,5 @@
+from dbt.tests.adapter.unit_testing.test_invalid_input import BaseUnitTestInvalidInput
+
+
+class TestInvalidInput(BaseUnitTestInvalidInput):
+    pass

tests/integration/adapter/unit_testing/test_types.py

@@ -0,0 +1,31 @@
+import pytest
+from dbt.tests.adapter.unit_testing.test_types import BaseUnitTestingTypes
+
+
+class TestingTypes(BaseUnitTestingTypes):
+    @pytest.fixture
+    def data_types(self):
+        # sql_value, yaml_value
+        return [
+            ["1", "1"],
+            ["'1'", "1"],
+            ["true", "true"],
+            ["DATE '2020-01-02'", "2020-01-02"],
+            [
+                "TIMESTAMP '2013-11-03 00:00:00'",
+                "2013-11-03 00:00:00",
+            ],  # Overridden: no "-0" support
+            [
+                "'2023-10-29 01:30:00'::DateTime('UTC')",
+                "2013-11-03 00:00:00",
+            ],  # Overridden: no "-0" support and timezones expressed differently
+            ["'1'::numeric", "1"],
+            # Not fully supported types:
+            # [
+            # """'{"bar": "baz", "balance": 7.77, "active": false}'::json""",
+            #     """'{"bar": "baz", "balance": 7.77, "active": false}'""",
+            # ],
+            # TODO: support complex types <-- this TODO came from the DBT test.
+            # ["ARRAY['a','b','c']", """'{"a", "b", "c"}'"""],
+            # ["ARRAY[1,2,3]", """'{1, 2, 3}'"""],
+        ]