Skip to content

Conversation

@Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 21, 2025

Summary

Important

With the upgraded PHPCS, there are lots of warnings reported.

  • Updated the PHPCS
  • Fixed some new errors reported
  • Made the GitHub Action to check only the errors since there are lots of warnings

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

  • Check if everything is fine

Check before Pull Request is ready:

Closes #.

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 21, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 1, 2025 07:49
@pirate-bot
Copy link
Contributor

Plugin build for 413a133 is ready 🛎️!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the PHPCS changed and not each individual change here, we can also see why the e2e is failing after the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants