chore: remove eslint-plugin-github

Author: Codex-

eslint.config.mjs

@@ -1,35 +1,10 @@
 // @ts-check
 
-import { fixupPluginRules } from "@eslint/compat";
-import { FlatCompat } from "@eslint/eslintrc";
 import jsEslint from "@eslint/js";
 import eslintConfigPrettier from "eslint-config-prettier";
 import eslintPluginImportX from "eslint-plugin-import-x";
 import * as tsEslint from "typescript-eslint";
 
-const compat = new FlatCompat({
-  baseDirectory: import.meta.dirname,
-  recommendedConfig: jsEslint.configs.recommended,
-  allConfig: jsEslint.configs.all,
-});
-
-/* eslint-disable @typescript-eslint/explicit-function-return-type */
-/**
- * @param {string} name the pugin name
- * @param {string} alias the plugin alias
- * @returns {import("eslint").ESLint.Plugin}
- */
-function legacyPlugin(name, alias = name) {
-  const plugin = compat.plugins(name)[0]?.plugins?.[alias];
-
-  if (!plugin) {
-    throw new Error(`Unable to resolve plugin ${name} and/or alias ${alias}`);
-  }
-
-  return fixupPluginRules(plugin);
-}
-/* eslint-enable @typescript-eslint/explicit-function-return-type */
-
 export default tsEslint.config(
   jsEslint.configs.recommended,
   eslintPluginImportX.flatConfigs.recommended,
@@ -55,10 +30,6 @@ export default tsEslint.config(
     ],
   },
   {
-    plugins: {
-      github: legacyPlugin("eslint-plugin-github", "github"), // pending https://github.com/github/eslint-plugin-github/issues/513
-      import: legacyPlugin("eslint-plugin-import", "import"), // Needed for above
-    },
     rules: {
       "@typescript-eslint/await-thenable": "warn",
       "@typescript-eslint/explicit-function-return-type": "warn",
@@ -79,19 +50,15 @@ export default tsEslint.config(
           allowNumber: true,
         },
       ],
-      "github/array-foreach": "error",
-      "github/no-implicit-buggy-globals": "error",
-      "github/no-then": "error",
-      "github/no-dynamic-script-tag": "error",
-      "import/no-extraneous-dependencies": [
+      "import-x/no-extraneous-dependencies": [
         "error",
         {
           devDependencies: true,
           optionalDependencies: true,
           peerDependencies: true,
         },
       ],
-      "import/order": [
+      "import-x/order": [
         "warn",
         { "newlines-between": "always", alphabetize: { order: "asc" } },
       ],

package.json

@@ -34,29 +34,25 @@
     "uuid": "^10.0.0"
   },
   "devDependencies": {
-    "@eslint/compat": "^1.2.3",
-    "@eslint/eslintrc": "^3.2.0",
     "@eslint/js": "^9.16.0",
     "@opentf/std": "^0.13.0",
     "@total-typescript/ts-reset": "^0.6.1",
     "@types/eslint__js": "^8.42.3",
     "@types/node": "~20.17.9",
     "@types/uuid": "^10.0.0",
-    "@typescript-eslint/eslint-plugin": "^8.16.0",
-    "@typescript-eslint/parser": "^8.16.0",
+    "@typescript-eslint/eslint-plugin": "^8.18.0",
+    "@typescript-eslint/parser": "^8.18.0",
     "@vitest/coverage-v8": "^2.1.6",
     "chalk": "^5.3.0",
     "changelogithub": "^0.13.11",
     "esbuild": "^0.24.0",
     "eslint": "^9.16.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.3",
-    "eslint-plugin-github": "^5.1.3",
-    "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-import-x": "^4.4.3",
+    "eslint-import-resolver-typescript": "^3.7.0",
+    "eslint-plugin-import-x": "^4.5.0",
     "prettier": "3.4.1",
     "typescript": "^5.7.2",
-    "typescript-eslint": "^8.16.0",
+    "typescript-eslint": "^8.18.0",
     "vitest": "^2.1.6"
   }
 }