Skip to content

Commit 235fdfa

Browse files
Merge pull request #1991 from sophiemoustard/COM-3697
COM-3697: update chart.js
2 parents 88dd441 + 4718ef0 commit 235fdfa

File tree

4 files changed

+33
-31
lines changed

4 files changed

+33
-31
lines changed

package-lock.json

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"@vuelidate/validators": "~2.0.4",
2323
"axios": "~1.6.7",
2424
"bignumber.js": "~9.1.2",
25-
"chart.js": "~3.8.0",
25+
"chart.js": "~4.4.2",
2626
"connect-history-api-fallback": "~2.0.0",
2727
"date-holidays": "~3.23.7",
2828
"dotenv": "~16.4.1",
@@ -39,7 +39,7 @@
3939
"quasar": "~2.13.1",
4040
"vue": "~3.4.19",
4141
"vue-advanced-cropper": "~2.8.1",
42-
"vue-chart-3": "~3.1.8",
42+
"vue-chartjs": "~5.3.1",
4343
"vue-router": "~4.2.5",
4444
"vuedraggable": "~4.1.0",
4545
"vuelidate": "~0.7.6",

src/core/components/charts/LineChart.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
<div>
33
<q-card flat class="q-pa-md">
44
<div class="text-weight-bold q-mb-md">{{ title }}</div>
5-
<vue-chart-line-chart v-bind="lineChartProps" class="line-chart" />
5+
<vue-chart-line-chart :options="options" :data="chartData" class="line-chart" />
66
</q-card>
77
</div>
88
</template>
99

1010
<script>
1111
import { getCssVar } from 'quasar';
1212
import { toRefs, computed } from 'vue';
13-
import { LineChart as VueChartLineChart, useLineChart } from 'vue-chart-3';
13+
import { Line as VueChartLineChart } from 'vue-chartjs';
1414
import { Chart, registerables } from 'chart.js';
1515
1616
Chart.register(...registerables);
@@ -48,10 +48,10 @@ export default {
4848
maintainAspectRatio: false,
4949
}));
5050
51-
const { lineChartProps } = useLineChart({ options, chartData });
52-
5351
return {
54-
lineChartProps,
52+
// Computed
53+
options,
54+
chartData,
5555
};
5656
},
5757
};

src/core/components/courses/ProfileFollowUp.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
<div class="self-center justify-center column learners-data">
99
<div class="row items-center">
1010
<ni-e-learning-indicator :indicator="traineesOnGoingCount" class="q-pr-sm" />
11-
<div>apprenant{{ traineesOnGoingCount > 1 ? 's' : '' }} en cours</div>
11+
<div>{{ formatQuantity('apprenant',traineesOnGoingCount, 's', false) }} en cours</div>
1212
</div>
1313
<div class="row items-center">
1414
<ni-e-learning-indicator :indicator="traineesFinishedCount" class="q-pr-sm" />
15-
<div>apprenant{{ traineesFinishedCount > 1 ? 's' : '' }} ayant terminé</div>
15+
<div>{{ formatQuantity('apprenant', traineesFinishedCount, 's', false) }} ayant terminé</div>
1616
</div>
1717
</div>
1818
</q-card>
@@ -33,6 +33,7 @@ import { useTraineeFollowUp } from '@composables/traineeFollowUp';
3333
import { useCharts } from '@composables/charts';
3434
import CompaniDate from '@helpers/dates/companiDates';
3535
import { MONTH, DAY } from '@data/constants';
36+
import { formatQuantity } from '@helpers/utils';
3637
3738
export default {
3839
name: 'ProfileFollowUp',
@@ -85,6 +86,7 @@ export default {
8586
traineesOnGoingCount,
8687
traineesFinishedCount,
8788
// Methods
89+
formatQuantity,
8890
};
8991
},
9092
};

0 commit comments

Comments
 (0)