Skip to content

Add function to toggle on/off IP Validation in Enhanced Permissioing NodeManager #1678

@john-sobrepena-partior

Description

@john-sobrepena-partior

Rationale

Use case
We are running a 1st Quorum node in kubernetes pod with Enhanced Permissioning v2 enabled. A 2nd quorum node is hosted in another kubernetes cluster / namespace also running Enhanced Permissioning v2. The 1st and 2nd quorum node's enodeIds, ports and IP addresses were added to the list of nodes that are allowed to connect. The geth API quorumPermission_addNode() was used.

However, the 1st and 2nd node are not able to connect to each other because, for example - the incoming connection from 2nd node's IP has changed. Based on discussion with our infra team, and due to securities in place, the IP address of incoming connection may change or re-written before the connection request finally reach the pod where the other Quorum node is running. Due to this, the connectionAllowed() of v2/contract/NodeManager.sol rejects the connection.

Implementation

Do you have ideas regarding the implementation of this feature? Yes
Are you willing to implement this feature? Yes

Proposed Solution / Changes
I am proposing in this change to introduce a setIpValidation() function in NodeManager.sol to toggle IP validation on or off. This is enabled by default. The property can only be set before network boot status is finalized.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions