Packages spin if frogport cannot accept package

[HighMarsOrbit]

Description

I noticed that if a frogport encounters a frogport that cannot accept packages (because it is full, for example), it will spin, even if further frogports down the line are able to accept the package. To reproduce, set up some frogports in a line, fill the first one, and release a package. It will spin, even if the later frogports are open. If you remove that frogport, the package will continue down the line.

Link yo YouTube video with bug: https://youtu.be/RDVzmSLrWPg

Game Log

https://mclo.gs/QIcyM1e

Debug Information

Client Info

Create:
	Mod Version: 6.0.1
	NeoForge Version: 21.1.128
	Minecraft Version: 1.21.1

Graphics:
	Flywheel Version: 1.0.1-11
	Flywheel Backend: flywheel:indirect
	OpenGL Renderer: NVIDIA GeForce RTX 4070/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 560.94
	Graphics Mode: Fancy

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.3, Microsoft
	JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	Memory: 490751008 bytes (468 MiB) / 2147483648 bytes (2048 MiB) up to 2147483648 bytes (2048 MiB)
	Total Memory: 21653057536 bytes (20641 MiB) / 68422565888 bytes (65226 MiB)
	CPU: Intel(R) Core(TM) i9-14900K @ 3.19 GHz; 24 cores / 32 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
	WorldEdit: 7.3.8+6939-7d32b45
	Ponder: 1.0.39

Server Info

Create:
	Mod Version: 6.0.1
	NeoForge Version: 21.1.128
	Minecraft Version: 1.21.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.3, Microsoft
	JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	Memory: 490751008 bytes (468 MiB) / 2147483648 bytes (2048 MiB) up to 2147483648 bytes (2048 MiB)
	Total Memory: 21653057536 bytes (20641 MiB) / 68422565888 bytes (65226 MiB)
	CPU: Intel(R) Core(TM) i9-14900K @ 3.19 GHz; 24 cores / 32 threads on 1 socket(s)
	Graphics cards: none

Other Mods:
	WorldEdit: 7.3.8+6939-7d32b45
	Ponder: 1.0.39

[HighMarsOrbit]

Some more info: I think this bug only occurs when the frogport is linked to a conveyor hub directly, not to the chain between them.

[wen999di]

No, this also happens when a frogport is linked to the chain. This seems to be due to the package routing only searching for the closest frogport and only routing when a package is created. This problem can also occur if the chain is suddenly changed when there are a lot of packages, but I can't reproduce it 100% of the time, so I can't say for sure which specific reason is causing the problem.

[HighMarsOrbit]

I think a way to fix this would be to remove a frogport from the routing table if it cannot accept any more packages. As is, it makes expandable modular storage systems nearly impossible as the packages will just circle around the first storage ports on the chain because they won't go past the junction.

[wen999di]

And existing packages don't seem to be rerouted when frogport changes the address.