Factory Gauges order crafts for items already in stock when area is reloaded

[jsburger]

I've been having an issue on my server where I'll return to my base and some arbitrary items are ordered despite already having them in stock, resulting in overstocking and general bankruptcy of my resources. My warehouse consists of 8 small vaults, 4 in one chunk, 4 in another adjacent chunk (all have stock links and packagers attached). The factory gauges are all in one, separate chunk. There is a gap of about 3 chunks in between the warehouse and the gauges. Rogue orders have never come in while I was in my base, even for extended periods. While the rogue orders are being processed, I can see on the gauges that there are plenty of the requested item in storage.
I was able to prevent the issue by force loading my vaults, and have not had issues with it since (about 2 days ago).
The server is running 1.20.1 and Forge 47.4.0,

[iamkoen]

This happens in my single player world as well.

• When starting up the world.
• When switching dimensions or cause chunks to unload (this is fixed by chunk loading the stock link and attached inventory).
• When I attach a redstone link to the stock link to turn it off, and turn it back on.

Happens consistently, only on a handful of gauges at a time and seemingly at random which ones, and not the same ones every time.

Perhaps, and this is just guessing, this is happening because I moved around the stock links and factory gauges multiple times?
Or perhaps it is because I have multiple vaults with each their own (single) stock link attached and they are not correctly added up before the factory gauges queue up a request?

I suppose it can be temporarily fixed by setting a master switch on all factory gauges, to turn them off just before quitting the game, but I have quite a few (200+) all scattered around the factory, not really tempted :)

[vit112358]

Same thing here! Every time I enter my singleplayer world I have this problem. And for some reason the redstone link is not working to disable the requests.

[iamkoen]

My best (uninformed) guess is that the Factory Gauges load before the Stock Links and/or their inventories are loaded.

Currently my workaround is, to force load the chunk that has my main storage Stock Links and exit the game while in the Nether or far away from the base.
This forces the main storage Stock Links to load before the chunks that have the Factory Gauges on the next start/login. So far that has worked.

[zznty]

I had this issue with my fluid variant of gauges and was able to debug this consistently a few weeks ago.
turns out packager inventory behaviour was reporting no inventory found for the first tick, so the gauge gets zero items in stock and requests more

[OshidaBCF]

i wasn't actually noticing that it was crafting "surplus"

this is rather annoying because i keep teleporting to and from my base so i keep making stock

at least my base resources are infinite

I am guess that this is caused by server lag perhaps, because it wasn't doing that before, and now even when i look at a vault with JADE it takes a moment before showing it's content, so i guess the same happen to the stock tickers

perhaps some kind of "timeout" could be added to gauges when chunks load so it's sure that everything is loaded properly

[Phaired]

when i look at a vault with JADE it takes a moment before showing it's content

i have the same behaviour but on my server (locally hosted) we are around 10-15ms per ticks so we can consider this as no lag at all

[OshidaBCF]

as long as it's less than 50 ms per tick server will run at 20 TPS, so yeah you don't have lag

our server don't have lag either but it' just take some time for the game to merge the inventory of the vaults for some reason

you can see sometime on big vault the list of item increasing every ticks while it calculate evertyhing

[OshidaBCF]

The bug is becoming increasingly funny to look at i will be honest

ate all of my cobble making stone and observers

[sssxks]

i guess why this bug is not that often seen is because the factory gauges timer is default to 100, therefore hiding the issue. change it to 5 will trigger the bug almost every time entering a world.

[OshidaBCF]

i guess why this bug is not that often seen is because the factory gauges timer is default to 100, therefore hiding the issue. change it to 5 will trigger the bug almost every time entering a world.

i don't think we changed the value of the factory gauges on the server, but the server itself is running a little slower than what would be called "optimal" (like 14-16 TPS)

and it still happen on every chunk load

[sssxks]

i asked o3 to fix and it found this

private InventorySummary getRelevantSummary() {
	FactoryPanelBlockEntity panelBE = panelBE();
	if (!panelBE.restocker)
		return LogisticsManager.getSummaryOfNetwork(network, false);
	PackagerBlockEntity packager = panelBE.getRestockedPackager();
	if (packager == null)
		return InventorySummary.EMPTY;
	return packager.getAvailableItems(true);
}

o3 changed getSummaryOfNetwork(network, false); to getSummaryOfNetwork(network, true);

and it seems to have fixed the issue