Bush Compatibility for Mods

[JPAKx4]

Cobblemon Dev here trying to fix an incompatibility with our berry blocks and the harvester.

Based on my understanding of HarvesterMovementBehaviour.java, the only reason Sweet Berry Bushes works is because it is hardcoded to reduce age to 1 to keep the bush at full size. I would like it to be possible for me to tell Create what the age I want the crop reduced to, and the age that the plant can be harvested at (max age by default).

[SpencerLommel]

so you would like to modify the api so when a harvester harvests a crop it can set it's age to something else besides 0?

and then also harvest crops before the reach maximum age as well?

[JPAKx4]

The first one is the most important part for us, as similar to the Sweet Berry Bush we need to keep the bush at a higher age than 0 when harvested.

The second is part of how sweet berry bushes work where you can harvest them at both age 2 and 3, although we don't use this mechanic. Implementing this could be important for some mods and to make it so berry bushes aren't hard coded.

[SpencerLommel]

The second is part of how sweet berry bushes work where you can harvest them at both age 2 and 3, although we don't use this mechanic. Implementing this could be important for some mods and to make it so berry bushes aren't hard coded.

I agree with this, crops will probably need some custom attribute like ageValueAfterHarvest and perhaps ageValueToHarvest and then we can just check for if an instance of CropBlock has either of these attributes when harvesting.

Sweet Berry Bushes will probably remain hardcoded though as if we added a property like this it would also need to be implemented to the sweet berry instance of CropBlock which would be doable but probably unnecessary

[WhyNotDogie]

why can't we let blocks define their own "mechanical harvestation" behavior? let them do literally whatever they want when being harvested.

[adaliszk]

That would be a cool idea, create tag for other developers to add to their crops and create just applies that. Though, currently, the modded crops should just work if they actually extend the relevant minecraft classes (CropBlock/GrowingPlantBlock):

Create/src/main/java/com/simibubi/create/content/contraptions/actors/harvester/HarvesterMovementBehaviour.java

Lines 99 to 160 in e0c859a

	public boolean isValidCrop(Level world, BlockPos pos, BlockState state) {
	boolean harvestPartial = AllConfigs.server().kinetics.harvestPartiallyGrown.get();
	boolean replant = AllConfigs.server().kinetics.harvesterReplants.get();
	if (state.getBlock() instanceof CropBlock crop) {
	if (harvestPartial)
	return state != crop.getStateForAge(0) || !replant;
	return crop.isMaxAge(state);
	}
	if (state.getCollisionShape(world, pos)
	.isEmpty() || state.getBlock() instanceof CocoaBlock) {
	for (Property<?> property : state.getProperties()) {
	if (!(property instanceof IntegerProperty ageProperty))
	continue;
	if (!property.getName()
	.equals(BlockStateProperties.AGE_1.getName()))
	continue;
	int age = state.getValue(ageProperty)
	.intValue();
	if (state.getBlock() instanceof SweetBerryBushBlock && age <= 1 && replant)
	continue;
	if (age == 0 && replant || !harvestPartial && (ageProperty.getPossibleValues()
	.size() - 1 != age))
	continue;
	return true;
	}
	}
	return false;
	}
	public boolean isValidOther(Level world, BlockPos pos, BlockState state) {
	if (state.getBlock() instanceof CropBlock)
	return false;
	if (state.getBlock() instanceof SugarCaneBlock)
	return true;
	if (state.is(BlockTags.LEAVES))
	return true;
	if (state.getBlock() instanceof CocoaBlock)
	return state.getValue(CocoaBlock.AGE) == CocoaBlock.MAX_AGE;
	if (state.getCollisionShape(world, pos)
	.isEmpty()) {
	if (state.getBlock() instanceof GrowingPlantBlock)
	return true;
	for (Property<?> property : state.getProperties()) {
	if (!(property instanceof IntegerProperty))
	continue;
	if (!property.getName()
	.equals(BlockStateProperties.AGE_1.getName()))
	continue;
	return false;
	}
	if (state.getBlock() instanceof IPlantable)
	return true;
	}
	return false;
	}

Maybe something to consider if create goes for the more component-data system direction at some point.

[adaliszk]

As for now, how would an interface sounds like? Simply exposing one that can by type-checked on the create side and then call lets say a bool harvest() and bool replant() based on the create configs to let other mods implement the integration?

[JPAKx4]

That sounds like it would work great for us @adaliszk, could let a lot of dynamic behavior to be added.

[VoidLeech]

A SimpleRegistry of those would be better (or at the very least as an alternative) because then the api doesn't require either hard depending on Create or self-mixins.

[JPAKx4]

@VoidLeech That would be fine as well, I was going to consult the team to see if we could dynamically mixin or if we just needed a small compat mod with the interface option.