Enable more Go linters and document exclusions

Author: cbandy

.github/workflows/lint.yaml

@@ -28,12 +28,8 @@ jobs:
       # exits zero to ensure it does not fail the pull request check.
       - name: Count non-blocking issues
         run: |
-          golangci-lint run --config .golangci.next.yaml \
-            --issues-exit-code 0 \
-            --max-issues-per-linter 0 \
-            --max-same-issues 0 \
-            --out-format json |
-          jq --sort-keys 'reduce .Issues[] as $i ({}; .[$i.FromLinter] += 1)' |
-          awk >> "${GITHUB_STEP_SUMMARY}" '
-            NR == 1 { print "```json" } { print } END { if (NR > 0) print "```" }
-          ' || true
+          golangci-lint run --config .golangci.next.yaml --show-stats >> "${GITHUB_STEP_SUMMARY}" \
+            --max-issues-per-linter=0 \
+            --max-same-issues=0 \
+            --uniq-by-line=0 \
+            --output.text.path=/dev/null ||:

.golangci.bck.yaml

@@ -1,44 +1,98 @@
-# https://golangci-lint.run/usage/configuration/
+# https://golangci-lint.run/usage/configuration
 #
 # This file is for linters that might be interesting to enforce in the future.
 # Rules that should be enforced immediately belong in [.golangci.yaml].
 #
 # Both files are used by [.github/workflows/lint.yaml].
+version: "2"
 
+# https://golangci-lint.run/usage/linters
 linters:
-  disable-all: true
-  enable:
-    - contextcheck
-    - err113
-    - gocritic
-    - godot
-    - godox
-    - gofumpt
-    - gosec # exclude-use-default
-    - nilnil
+  default: all
+  disable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - copyloopvar
+    - depguard
+    - dupword
+    - durationcheck
+    - errchkjson
+    - errname
+    - errorlint
+    - exhaustive
+    - exptostd
+    - fatcontext
+    - forbidigo
+    - ginkgolinter
+    - gocheckcompilerdirectives
+    - gochecksumtype
+    - goheader
+    - gomoddirectives
+    - gomodguard
+    - goprintffuncname
+    - gosmopolitan
+    - grouper
+    - iface
+    - importas
+    - interfacebloat
+    - intrange
+    - loggercheck
+    - makezero
+    - mirror
+    - misspell
+    - musttag
+    - nilerr
+    - nilnesserr
+    - noctx
     - nolintlint
-    - predeclared
-    - revive
-    - staticcheck # exclude-use-default
-    - tenv
-    - thelper
-    - tparallel
+    - nosprintfhostport
+    - prealloc
+    - promlinter
+    - protogetter
+    - reassign
+    - recvcheck
+    - rowserrcheck
+    - sloglint
+    - spancheck
+    - sqlclosecheck
+    - tagalign
+    - testifylint
+    - unconvert
+    - unparam
+    - usestdlibvars
+    - usetesting
     - wastedassign
-  presets:
-    - performance
+    - wsl
+    - zerologlint
 
-issues:
-  exclude-rules:
-    # We call external linters when they are installed: Flake8, ShellCheck, etc.
-    - linters: [gosec]
-      path: '_test[.]go$'
-      text: 'G204: Subprocess launched with variable'
+  settings:
+    thelper:
+      # https://github.com/kulti/thelper/issues/27
+      tb:   { begin: true, first: true }
+      test: { begin: true, first: true, name: true }
+
+  exclusions:
+    warn-unused: true
+    # Ignore built-in exclusions
+    presets: []
+    rules:
+      # We call external linters when they are installed: Flake8, ShellCheck, etc.
+      - linters: [gosec]
+        path: '_test[.]go$'
+        text: 'G204: Subprocess launched with variable'
 
-  # https://github.com/golangci/golangci-lint/issues/2239
-  exclude-use-default: false
+# https://golangci-lint.run/usage/formatters
+formatters:
+  enable:
+    - gofumpt
+
+issues:
+  # Fix only when requested
+  fix: false
 
-linters-settings:
-  thelper:
-    # https://github.com/kulti/thelper/issues/27
-    tb:   { begin: true, first: true }
-    test: { begin: true, first: true, name: true }
+  # Show all issues at once
+  max-issues-per-linter: 0
+  max-same-issues: 0
+  uniq-by-line: false