feat: add alb_internal_default_target_group_arn variable #70
Conversation
Allow users to specify a custom target group ARN for the internal ALB HTTPS listener default action. If not specified, falls back to the default target group created by the module. This enables external deployment tools (e.g., GitHub Actions) to manage the listener default action without Terraform reverting changes.
|
⏳ Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion. Using Amazon Q Developer for GitHubAmazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation. Slash Commands
FeaturesAgentic Chat Code Review CustomizationYou can create project-specific rules for Amazon Q Developer to follow:
Example rule: FeedbackTo provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository. For more detailed information, visit the Amazon Q for GitHub documentation. Footnotes
|
|
Add support for custom target group in internal ALB listener
Summary
Adds
alb_internal_default_target_group_arnvariable to allow users to specify a custom target group ARN for the internal ALB HTTPS listener default action.Motivation
When using external deployment tools (e.g., GitHub Actions, CodeDeploy) that manage ALB listener routing, Terraform would revert the listener's default action back to the module-created default target group on subsequent runs. This change allows users to align Terraform configuration with externally managed listener configurations.
Changes
alb_internal_default_target_group_arnvariable to_variables.tfalb-internal.tfto use the custom target group ARN when providedUsage Example
hcl
module "ecs_cluster" {
source = "git::https://github.com/DNXLabs/terraform-aws-ecs.git?ref=6.20.1"
name = "my-cluster"
alb_internal = true
alb_internal_default_target_group_arn = "arn:aws:elasticloadbalancing:region:account:targetgroup/my-app/abc123"
... other variables
}
Backward Compatibility
Fully backward compatible. When
alb_internal_default_target_group_arnis not set or empty, behavior remains unchanged.Testing
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to <repo_name>?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...