Allow judging the remaining testcases as analyst

Author: Kevinjil

webapp/src/Controller/API/JudgehostController.php

@@ -1083,7 +1083,7 @@ private function addSingleJudgingRun(
                     throw new BadMethodCallException('internal bug: the evaluated result changed during judging');
                 }
 
-                if ($$lazyEval === DOMJudgeService::EVAL_ANALYST) {
+                if ($lazyEval === DOMJudgeService::EVAL_ANALYST) {
                     // Explicitly do not update priorities or cancel activated tasks.
                 } elseif ($lazyEval !== DOMJudgeService::EVAL_FULL) {
                     // We don't want to continue on this problem, even if there's spare resources.

webapp/src/Controller/Jury/JudgeRemainingTrait.php

@@ -5,6 +5,7 @@
 use App\Entity\JudgeTask;
 use App\Entity\Judging;
 use App\Entity\QueueTask;
+use App\Service\DOMJudgeService;
 
 trait JudgeRemainingTrait
 {
@@ -13,13 +14,14 @@ trait JudgeRemainingTrait
      */
     protected function judgeRemainingJudgings(array $judgings): void
     {
+        $lazyEval = $this->config->get('lazy_eval_results');
         $inProgress = [];
         $alreadyRequested = [];
         $invalidJudgings = [];
         $numRequested = 0;
         foreach ($judgings as $judging) {
             $judgingId = $judging->getJudgingid();
-            if ($judging->getResult() === null) {
+            if ($judging->getResult() === null && $lazyEval !== DOMJudgeService::EVAL_ANALYST) {
                 $inProgress[] = $judgingId;
             } elseif ($judging->getJudgeCompletely()) {
                 $alreadyRequested[] = $judgingId;

webapp/src/Controller/Jury/SubmissionController.php

@@ -583,6 +583,7 @@ public function viewAction(
             'version_warnings' => [],
             'isMultiPassProblem' => $submission->getProblem()->isMultipassProblem(),
             'thumbnailSize' => $this->config->get('thumbnail_size'),
+            'isAnalystMode' => $this->config->get('lazy_eval_results') === DOMJudgeService::EVAL_ANALYST,
         ];
 
         if ($selectedJudging === null) {

webapp/templates/jury/submission.html.twig

@@ -541,7 +541,7 @@
                                 {% if selectedJudging is not null and runsOutstanding %}
                                     {% if selectedJudging.judgeCompletely %}
                                         <i class="fas fa-balance-scale" title="remaining test cases requested to be judged"></i>
-                                    {% elseif selectedJudging.result is not null %}
+                                    {% elseif selectedJudging.result is not null or isAnalystMode %}
                                         <form action="{{ path('jury_submission_request_remaining', {'judgingId': selectedJudging.judgingid}) }}" method="post"
                                               style="display: inline; ">
                                             <button type="submit" class="btn btn-outline-secondary btn-sm" style="padding: 0.1rem 0.5rem; font-size: 0.7em"><i class="fa-solid fa-gavel"></i> judge remaining</button>