Skip to content

Commit e4c2a3e

Browse files
committed
commiting changes
1 parent 2a57524 commit e4c2a3e

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

ray-operator/controllers/ray/rayjob_controller.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,6 @@ func initRayJobStatusIfNeed(ctx context.Context, rayJob *rayv1.RayJob) error {
859859
if rayJob.Status.JobStatus == "" {
860860
rayJob.Status.JobStatus = rayv1.JobStatusNew
861861
}
862-
863862
rayJob.Status.JobDeploymentStatus = rayv1.JobDeploymentStatusInitializing
864863
rayJob.Status.StartTime = &metav1.Time{Time: time.Now()}
865864
return nil
@@ -954,7 +953,6 @@ func (r *RayJobReconciler) constructRayClusterForRayJob(rayJobInstance *rayv1.Ra
954953

955954
func (r *RayJobReconciler) getNextAndPreviousScheduleDistance(ctx context.Context, currentTime time.Time, rayJobInstance *rayv1.RayJob) (time.Duration, time.Duration, error) {
956955
logger := ctrl.LoggerFrom(ctx)
957-
logger.Info("Calculating next schedule for the RayJob")
958956
formatedCron := utils.FormatSchedule(rayJobInstance, r.Recorder)
959957
cronSchedule, err := cron.ParseStandard(formatedCron)
960958
if err != nil {
@@ -963,7 +961,6 @@ func (r *RayJobReconciler) getNextAndPreviousScheduleDistance(ctx context.Contex
963961
r.Recorder.Eventf(rayJobInstance, corev1.EventTypeWarning, "UnparseableSchedule", "unparseable schedule: %q : %s", rayJobInstance.Spec.Schedule, err)
964962
return 0, 0, fmt.Errorf("the cron schedule provided is unparseable: %w", err)
965963
}
966-
logger.Info("Successfully parsed cron schedule", "CronSchedule", formatedCron)
967964

968965
t1 := utils.NextScheduleTimeDuration(logger, rayJobInstance, currentTime, cronSchedule)
969966
t2 := utils.LastScheduleTimeDuration(logger, rayJobInstance, currentTime, cronSchedule)

ray-operator/controllers/ray/rayjob_controller_unit_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -626,10 +626,6 @@ func TestEmitRayJobExecutionDuration(t *testing.T) {
626626
}
627627

628628
func TestGetNextAndPreviousScheduleDistance(t *testing.T) {
629-
// Test 1, the cron string is not valid
630-
// Test 2, we are not within the the buffer period of a cron tick to run a ray job
631-
// Test 3, we are within the buffer period of a cron tick to run a ray job
632-
633629
newScheme := runtime.NewScheme()
634630
_ = rayv1.AddToScheme(newScheme)
635631
_ = corev1.AddToScheme(newScheme)

0 commit comments

Comments
 (0)