Skip to content

Commit 9bc659b

Browse files
jorgetomtzbrettlangdon
authored andcommitted
ci: add vpa template configuration with 2x oom scaling factor and min cap (#13669)
<details open><summary> # Problem </summary> We are looking into modifying the default template used for VPA. </details> <details open><summary> # Solution </summary> Set the annotation globally </details> <details><summary> # Testing Done </summary> https://app.datadoghq.com/s/yB5yjZ/xr8-36s-ip6 </details> ## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 462b456 commit 9bc659b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.gitlab-ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ variables:
1010
REPO_NOTIFICATION_CHANNEL: "#apm-python-release"
1111
RELEASE_ALLOW_TEST_FAILURES: false
1212
RELEASE_ALLOW_BENCHMARK_FAILURES: false
13-
DD_DISABLE_VPA: true
13+
# VPA Template configuration
14+
DD_VPA_TEMPLATE: "vpa-template-cpu-p70-10percent-2x-oom-min-cap"
1415
# CI_DEBUG_SERVICES: "true"
1516

1617
default:
@@ -76,7 +77,7 @@ microbenchmarks:
7677
variables:
7778
PARENT_PIPELINE_ID: $CI_PIPELINE_ID
7879
# Disable VPA for benchmarks
79-
KUBERNETES_POD_ANNOTATIONS_1: vpa.datadoghq.com/updateMode=Off
80+
DD_DISABLE_VPA: true
8081

8182
macrobenchmarks:
8283
stage: benchmarks
@@ -85,7 +86,7 @@ macrobenchmarks:
8586
include: .gitlab/benchmarks/macrobenchmarks.yml
8687
variables:
8788
# Disable VPA for benchmarks
88-
KUBERNETES_POD_ANNOTATIONS_1: vpa.datadoghq.com/updateMode=Off
89+
DD_DISABLE_VPA: true
8990
allow_failure: true
9091
rules:
9192
- if: $CI_PIPELINE_SOURCE == "schedule"

0 commit comments

Comments
 (0)