You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(ci_visibility): ensure spans are finished by the end of the session (#14066)
At the end of the test session, we finish all unfinished spans
recursively by calling `test_session.finish(force=True)`, but `force`
only applies if the item's current status is
`SPECIAL_STATUS.UNFINISHED`. It looks like in some obscure
circumstances, a test can be unfinished without having the
`SPECIAL_STATUS.UNFINISHED` status, and in this case the recursive
finish will ignore them. This PR changes the logic so that any
unfinished span is finished.
Also, test spans don't have a parent (they have their own context,
separate from the test session/module/suite). This means that when a
test span finishes, there is no parent to reactivate, and so there is no
active span. This confuses the logic that [checks for unfinished
spans](https://github.com/DataDog/dd-trace-py/blob/v3.10.2/ddtrace/_trace/tracer.py#L622)
when finish test session/module/suite. This PR reactivates the parent
span to avoid this issue.
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
0 commit comments