-
Notifications
You must be signed in to change notification settings - Fork 467
chore(aap): appsec tests in appsec files #15155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(aap): appsec tests in appsec files #15155
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 254 ± 8 ms. The average import time from base is: 256 ± 5 ms. The import time difference between this PR and base is: -2.0 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/put_appsec_tests_in_their_own_files (fab55bc) with baseline main (10e34b3) ❌ Test Failures (1 suite)❌ otelspan - 21/22✅ add-eventTime: ✅ 38.786ms (SLO: <47.150ms 📉 -17.7%) vs baseline: +0.4% Memory: ✅ 36.469MB (SLO: <47.000MB 📉 -22.4%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 258.489ms (SLO: <344.800ms 📉 -25.0%) vs baseline: -0.2% Memory: ✅ 40.757MB (SLO: <47.500MB 📉 -14.2%) vs baseline: +4.9% ❌ add-tagsTime: ❌ 316.150ms (SLO: <314.000ms +0.7%) vs baseline: +0.8% Memory: ✅ 40.698MB (SLO: <47.500MB 📉 -14.3%) vs baseline: +4.9% ✅ get-contextTime: ✅ 79.015ms (SLO: <92.350ms 📉 -14.4%) vs baseline: +0.2% Memory: ✅ 36.761MB (SLO: <46.500MB 📉 -20.9%) vs baseline: +5.1% ✅ is-recordingTime: ✅ 36.285ms (SLO: <44.500ms 📉 -18.5%) vs baseline: +0.1% Memory: ✅ 36.231MB (SLO: <47.500MB 📉 -23.7%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 56.512ms (SLO: <67.650ms 📉 -16.5%) vs baseline: -0.6% Memory: ✅ 36.828MB (SLO: <47.000MB 📉 -21.6%) vs baseline: +4.7% ✅ set-statusTime: ✅ 42.630ms (SLO: <50.400ms 📉 -15.4%) vs baseline: -0.2% Memory: ✅ 36.270MB (SLO: <47.000MB 📉 -22.8%) vs baseline: +5.0% ✅ startTime: ✅ 35.524ms (SLO: <43.450ms 📉 -18.2%) vs baseline: +0.2% Memory: ✅ 36.206MB (SLO: <47.000MB 📉 -23.0%) vs baseline: +4.9% ✅ start-finishTime: ✅ 81.771ms (SLO: <88.000ms -7.1%) vs baseline: +0.3% Memory: ✅ 34.013MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.377ms (SLO: <89.000ms -6.3%) vs baseline: +0.5% Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.8% ✅ update-nameTime: ✅ 37.016ms (SLO: <45.150ms 📉 -18.0%) vs baseline: -0.1% Memory: ✅ 36.266MB (SLO: <47.000MB 📉 -22.8%) vs baseline: +4.4% 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +1.1% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.3% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.6% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.338µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.3% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 1.473µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 0.614µs (SLO: <10.000µs 📉 -93.9%) vs baseline: ~same Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.284µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -1.0% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.4% ✅ bytes_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +0.8% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.4% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 0.433µs (SLO: <10.000µs 📉 -95.7%) vs baseline: ~same Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.0% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ casefold_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 0.423µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 0.705µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.5% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 3.560µs (SLO: <10.000µs 📉 -64.4%) vs baseline: +4.4% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 4.065µs (SLO: <10.000µs 📉 -59.3%) vs baseline: 📈 +12.9% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 0.777µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -2.4% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 0.360µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.8% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.3% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 1.350µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +0.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.7% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 2.597µs (SLO: <20.000µs 📉 -87.0%) vs baseline: -0.6% Memory: ✅ 37.139MB (SLO: <39.000MB -4.8%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.1% ✅ lower_aspectTime: ✅ 2.216µs (SLO: <10.000µs 📉 -77.8%) vs baseline: +0.6% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 2.218µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.8% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.5% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 1.003µs (SLO: <10.000µs 📉 -90.0%) vs baseline: +1.0% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.550µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +1.1% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 0.981µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.5% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.188µs (SLO: <10.000µs 📉 -88.1%) vs baseline: -1.7% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.625µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -3.3% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.868µs (SLO: <10.000µs 📉 -51.3%) vs baseline: -0.4% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.5% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.4% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 0.909µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.1% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.5% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 1.895µs (SLO: <20.000µs 📉 -90.5%) vs baseline: -1.4% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.4% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 1.563µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.6% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 0.721µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.5% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ strip_aspectTime: ✅ 2.519µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +13.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.390µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.9% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 2.400µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -0.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 0.536µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.1% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.346µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.5% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.3% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 3.227µs (SLO: <10.000µs 📉 -67.7%) vs baseline: ~same Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.225µs (SLO: <10.000µs 📉 -77.7%) vs baseline: ~same Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.7% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.213µs (SLO: <10.000µs 📉 -57.9%) vs baseline: +0.5% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.074µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -1.0% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.918µs (SLO: <10.000µs 📉 -30.8%) vs baseline: 📈 +12.7% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.834µs (SLO: <10.000µs 📉 -61.7%) vs baseline: 📈 +11.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.8% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.753µs (SLO: <10.000µs 📉 -52.5%) vs baseline: -0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: ~same Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.691µs (SLO: <10.000µs 📉 -63.1%) vs baseline: +1.8% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ ospathsplitext_aspectTime: ✅ 4.588µs (SLO: <10.000µs 📉 -54.1%) vs baseline: +3.0% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 1.392µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +1.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.271ms (SLO: <22.300ms 📉 -13.6%) vs baseline: -0.2% Memory: ✅ 66.057MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.4%) vs baseline: +0.6% Memory: ✅ 64.068MB (SLO: <67.000MB -4.4%) vs baseline: +4.8% ✅ iastTime: ✅ 19.297ms (SLO: <22.250ms 📉 -13.3%) vs baseline: +0.3% Memory: ✅ 65.900MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.402ms (SLO: <16.550ms -6.9%) vs baseline: +0.3% Memory: ✅ 53.787MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 19.355ms (SLO: <21.750ms 📉 -11.0%) vs baseline: +0.5% Memory: ✅ 65.934MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 22.839ms (SLO: <28.200ms 📉 -19.0%) vs baseline: -0.2% Memory: ✅ 66.996MB (SLO: <69.500MB -3.6%) vs baseline: +4.5% ✅ tracerTime: ✅ 19.266ms (SLO: <21.750ms 📉 -11.4%) vs baseline: +0.2% Memory: ✅ 66.006MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.258ms (SLO: <23.500ms -9.5%) vs baseline: +0.3% Memory: ✅ 67.826MB (SLO: <68.000MB 🟡 -0.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.260ms (SLO: <21.500ms 📉 -10.4%) vs baseline: -0.6% Memory: ✅ 65.857MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.714ms (SLO: <17.500ms -4.5%) vs baseline: +0.6% Memory: ✅ 65.858MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.5% ✅ tracer-nativeTime: ✅ 19.265ms (SLO: <21.750ms 📉 -11.4%) vs baseline: ~same Memory: ✅ 67.594MB (SLO: <72.500MB -6.8%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 17.325ms (SLO: <19.650ms 📉 -11.8%) vs baseline: +0.2% Memory: ✅ 66.002MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.741ms (SLO: <20.100ms -6.8%) vs baseline: +0.1% Memory: ✅ 65.823MB (SLO: <67.000MB 🟡 -1.8%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 18.967ms (SLO: <21.500ms 📉 -11.8%) vs baseline: ~same Memory: ✅ 65.860MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 19.101ms (SLO: <22.000ms 📉 -13.2%) vs baseline: ~same Memory: ✅ 65.894MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.591ms (SLO: <19.850ms 📉 -16.4%) vs baseline: +1.7% Memory: ✅ 65.736MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 16.377ms (SLO: <19.400ms 📉 -15.6%) vs baseline: +0.2% Memory: ✅ 65.598MB (SLO: <66.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 16.373ms (SLO: <19.450ms 📉 -15.8%) vs baseline: +0.4% Memory: ✅ 65.587MB (SLO: <66.500MB 🟡 -1.4%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.075ms (SLO: <2.300ms -9.8%) vs baseline: +0.4% Memory: ✅ 52.668MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.077ms (SLO: <2.250ms -7.7%) vs baseline: +0.6% Memory: ✅ 52.626MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.068ms (SLO: <2.300ms 📉 -10.1%) vs baseline: -0.2% Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.3% Memory: ✅ 62.089MB (SLO: <65.000MB -4.5%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.612ms (SLO: <6.750ms -2.0%) vs baseline: -0.3% Memory: ✅ 62.169MB (SLO: <65.000MB -4.4%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.4% Memory: ✅ 61.976MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: -0.4% Memory: ✅ 45.246MB (SLO: <47.000MB -3.7%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: -0.4% Memory: ✅ 42.235MB (SLO: <49.000MB 📉 -13.8%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.3% Memory: ✅ 46.508MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: -0.4% Memory: ✅ 52.660MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ tracerTime: ✅ 3.359ms (SLO: <3.650ms -8.0%) vs baseline: -0.5% Memory: ✅ 52.620MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.4% ✅ tracer-nativeTime: ✅ 3.360ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 54.001MB (SLO: <60.000MB -10.0%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.382µs (SLO: <20.000µs 📉 -83.1%) vs baseline: +9.0% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 206.391µs (SLO: <220.000µs -6.2%) vs baseline: +1.0% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.359µs (SLO: <20.000µs 📉 -83.2%) vs baseline: -2.5% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.573µs (SLO: <220.000µs 🟡 -1.1%) vs baseline: -0.7% Memory: ✅ 31.575MB (SLO: <34.000MB -7.1%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.222µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -3.1% Memory: ✅ 31.615MB (SLO: <34.000MB -7.0%) vs baseline: +5.2% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.573µs (SLO: <150.000µs -9.0%) vs baseline: -0.8% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.195µs (SLO: <20.000µs 📉 -84.0%) vs baseline: -0.9% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 220.261µs (SLO: <250.000µs 📉 -11.9%) vs baseline: +0.4% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.143ms (SLO: <22.000ms -8.4%) vs baseline: -1.3% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.269ms (SLO: <2.300ms 🟡 -1.3%) vs baseline: +1.4% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.413ms (SLO: <1.550ms -8.9%) vs baseline: +0.6% Memory: ✅ 31.615MB (SLO: <34.000MB -7.0%) vs baseline: +5.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.219ms (SLO: <2.550ms 📉 -13.0%) vs baseline: +0.6% Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.527µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +0.3% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 175.665µs (SLO: <250.000µs 📉 -29.7%) vs baseline: ~same Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.137ms (SLO: <2.500ms 📉 -14.5%) vs baseline: +0.3% Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%) vs baseline: +4.7%
|
…' of github.com:DataDog/dd-trace-py into christophe-papazian/put_appsec_tests_in_their_own_files
|
LGTM @christophe-papazian! |
emmettbutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thank you
mabdinur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits. Overall I love this change. In a follow up PR can we also introduce a new api for configuring asm/iast that doesn't require importing the global tracer?
Something like would be nice:
def configure_security_products(...):
****
Or we can just avoid exposing a programmatic api for enabling asm/iast (my preference). I think this would better align with next gen efforts
…ut_appsec_tests_in_their_own_files
Description
Basically, making sure we are accountable for ASM/AAP.
This PR will be followed by another one on the same topic (to not create huge PR)
APPSEC-59813