Fix failing specs

Author: y9v

spec/datadog/appsec/context_spec.rb

@@ -166,7 +166,7 @@
       end
 
       let(:run_result) do
-        Datadog::AppSec::SecurityEngine::Result::Error.new(duration_ext_ns: 0)
+        Datadog::AppSec::SecurityEngine::Result::Error.new(duration_ext_ns: 0, input_truncated: false)
       end
       let(:persistent_data) do
         {'server.request.query' => {'q' => "1' OR 1=1;"}}

spec/datadog/appsec/contrib/active_record/mysql2_adapter_spec.rb

@@ -133,7 +133,8 @@
           derivatives: {},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 

spec/datadog/appsec/contrib/active_record/postgresql_adapter_spec.rb

@@ -140,7 +140,8 @@
           derivatives: {},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 

spec/datadog/appsec/contrib/active_record/sqlite3_adapter_spec.rb

@@ -127,7 +127,8 @@
           derivatives: {},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 

spec/datadog/appsec/event_spec.rb

@@ -54,7 +54,8 @@
           },
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -210,7 +211,8 @@
           derivatives: {},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -282,7 +284,8 @@
           derivatives: {'dd.appsec.fp.http.endpoint' => 'http-post-c1525143-2d711642-1234567890'},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -364,7 +367,8 @@
           },
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 

spec/datadog/appsec/metrics/telemetry_spec.rb

@@ -16,7 +16,8 @@
     context 'when reporting a match run result' do
       let(:run_result) do
         Datadog::AppSec::SecurityEngine::Result::Match.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -33,7 +34,8 @@
     context 'when reporting a match run result with timeout' do
       let(:run_result) do
         Datadog::AppSec::SecurityEngine::Result::Match.new(
-          events: [], actions: {}, derivatives: {}, timeout: true, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: true, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -52,7 +54,8 @@
     context 'when reporting a ok run result' do
       let(:run_result) do
         Datadog::AppSec::SecurityEngine::Result::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -67,7 +70,8 @@
     context 'when reporting a ok run result with timeout' do
       let(:run_result) do
         Datadog::AppSec::SecurityEngine::Result::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: true, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: true, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -83,7 +87,7 @@
 
     context 'when reporting a error run result' do
       let(:run_result) do
-        Datadog::AppSec::SecurityEngine::Result::Error.new(duration_ext_ns: 0)
+        Datadog::AppSec::SecurityEngine::Result::Error.new(duration_ext_ns: 0, input_truncated: false)
       end
 
       it 'does not set WAF metrics on the span' do

spec/datadog/appsec/security_engine/result_spec.rb

@@ -12,7 +12,8 @@
           derivatives: {'3' => '3'},
           timeout: true,
           duration_ns: 400,
-          duration_ext_ns: 500
+          duration_ext_ns: 500,
+          input_truncated: false
         )
       end
 
@@ -22,25 +23,28 @@
       it { expect(result.derivatives).to eq({'3' => '3'}) }
       it { expect(result.duration_ns).to eq(400) }
       it { expect(result.duration_ext_ns).to eq(500) }
+      it { expect(result.input_truncated?).to eq(false) }
     end
 
     context 'when initializing error result' do
-      subject(:result) { described_class::Error.new(duration_ext_ns: 100) }
+      subject(:result) { described_class::Error.new(duration_ext_ns: 100, input_truncated: false) }
 
       it { expect(result).not_to be_timeout }
       it { expect(result.events).to eq([]) }
       it { expect(result.actions).to eq({}) }
       it { expect(result.derivatives).to eq({}) }
       it { expect(result.duration_ns).to eq(0) }
       it { expect(result.duration_ext_ns).to eq(100) }
+      it { expect(result.input_truncated?).to eq(false) }
     end
   end
 
   describe '#timeout?' do
     context 'when result indicates timeout' do
       subject(:result) do
         described_class::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: true, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: true, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -50,7 +54,8 @@
     context 'when result does not indicate timeout' do
       subject(:result) do
         described_class::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -62,7 +67,8 @@
     context 'when result is a generic type' do
       subject(:result) do
         described_class::Base.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -72,7 +78,8 @@
     context 'when result is a "match" type' do
       subject(:result) do
         described_class::Match.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -82,15 +89,16 @@
     context 'when result is an "ok" type' do
       subject(:result) do
         described_class::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
       it { expect(result).not_to be_match }
     end
 
     context 'when result is an "error" type' do
-      subject(:result) { described_class::Error.new(duration_ext_ns: 0) }
+      subject(:result) { described_class::Error.new(duration_ext_ns: 0, input_truncated: false) }
 
       it { expect(result).not_to be_match }
     end
@@ -100,7 +108,8 @@
     context 'when result is a generic type' do
       subject(:result) do
         described_class::Base.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -110,7 +119,8 @@
     context 'when result is a "match" type' do
       subject(:result) do
         described_class::Match.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -120,15 +130,16 @@
     context 'when result is an "ok" type' do
       subject(:result) do
         described_class::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
       it { expect(result).not_to be_error }
     end
 
     context 'when result is an "error" type' do
-      subject(:result) { described_class::Error.new(duration_ext_ns: 0) }
+      subject(:result) { described_class::Error.new(duration_ext_ns: 0, input_truncated: false) }
 
       it { expect(result).to be_error }
     end

spec/datadog/appsec/security_engine/runner_spec.rb

@@ -185,7 +185,9 @@
       end
 
       let(:waf_result) do
-        instance_double(Datadog::AppSec::WAF::Result, status: :err_invalid_object, timeout: false)
+        instance_double(
+          Datadog::AppSec::WAF::Result, status: :err_invalid_object, timeout: false, input_truncated?: false
+        )
       end
 
       it 'sends telemetry error' do
@@ -197,11 +199,13 @@
 
       context 'when WAF::Result#input_truncated? is true' do
         let(:waf_result) do
-          instance_double(Datadog::AppSec::WAF::Result, status: :err_invalid_object, timeout: true)
+          instance_double(
+            Datadog::AppSec::WAF::Result, status: :err_invalid_object, timeout: true, input_truncated?: true
+          )
         end
 
         it 'returns result with input_trucnated set to true' do
-          expect(result.input_truncated?).to be true
+          expect(waf_result.input_truncated?).to be true
         end
       end
     end
@@ -224,7 +228,7 @@
 
         expect(run_result).to be_kind_of(Datadog::AppSec::SecurityEngine::Result::Error)
         expect(run_result.duration_ext_ns).to be > 0
-        expect(result.input_truncated?).to be false
+        expect(run_result.input_truncated?).to be false
       end
     end
   end

spec/datadog/appsec/security_event_spec.rb

@@ -13,7 +13,8 @@
 
       let(:waf_result) do
         Datadog::AppSec::SecurityEngine::Result::Match.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -25,7 +26,8 @@
 
       let(:waf_result) do
         Datadog::AppSec::SecurityEngine::Result::Ok.new(
-          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0
+          events: [], actions: {}, derivatives: {}, timeout: false, duration_ns: 0, duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -34,7 +36,9 @@
 
     context 'when WAF result is an error' do
       subject(:event) { described_class.new(waf_result, trace: trace, span: span) }
-      let(:waf_result) { Datadog::AppSec::SecurityEngine::Result::Error.new(duration_ext_ns: 0) }
+      let(:waf_result) do
+        Datadog::AppSec::SecurityEngine::Result::Error.new(duration_ext_ns: 0, input_truncated: false)
+      end
 
       it { expect(event).not_to be_attack }
     end
@@ -51,7 +55,8 @@
           derivatives: {'_dd.appsec.s.req.headers' => [{'host' => [8], 'version' => [8]}]},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -68,7 +73,8 @@
           derivatives: {'not_schema' => 'value'},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -87,7 +93,8 @@
           derivatives: {'_dd.appsec.fp.http.endpoint' => 'http-post-c1525143-2d711642-'},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end
 
@@ -104,7 +111,8 @@
           derivatives: {'not_fingerprint' => 'value'},
           timeout: false,
           duration_ns: 0,
-          duration_ext_ns: 0
+          duration_ext_ns: 0,
+          input_truncated: false
         )
       end