Skip to content

Conversation

@dvp-git
Copy link
Contributor

@dvp-git dvp-git commented Nov 20, 2025

Added note about optional host parameter for database connection.

What does this PR do?

Updates inline comment on the host parameter in the conf.yaml.example file.

Motivation

https://datadog.zendesk.com/agent/tickets/2343561

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Added note about optional host parameter for database connection.
Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked language a bit but approving!

Comment on lines +45 to +46
## Note: optional only if the Database DSN's defined in db2cli.ini or db2dsdriver.cfg is copied to
## agents clidriver dirctory which is usually under `/opt/datadog-agent/embedded/lib/python3.9/site-packages/clidriver/cfg`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Note: optional only if the Database DSN's defined in db2cli.ini or db2dsdriver.cfg is copied to
## agents clidriver dirctory which is usually under `/opt/datadog-agent/embedded/lib/python3.9/site-packages/clidriver/cfg`
## Note: This parameter is optional only if the database DSN defined in
## db2cli.ini or db2dsdriver.cfg has been copied to the Agent’s
## clidriver directory, typically located at:
## /opt/datadog-agent/embedded/lib/python3.9/site-packages/clidriver/cfg

Copy link
Contributor

@HadhemiDD HadhemiDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make changes to the conf file, you need to update the assets/configuration/spec.yaml then run the ddev validate models <int-name> --sync
Add the no-changelog label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants