Debug MetadataNormalisationTest

Author: jbachorik

ddprof-test/src/test/java/com/datadoghq/profiler/AbstractProfilerTest.java

@@ -378,4 +378,29 @@ protected void verifyStackTraces(Path recording, String eventType, String... pat
     assertNotEquals(0, cumulatedEvents, "no events found for " + eventType);
     assertTrue(unmatched.isEmpty(), "couldn't find " + eventType + " with " + unmatched);
   }
+
+  protected final void checkContentionDrops() {
+      // Check profiler counters for contention drops
+      IItemCollection profilerCounters = verifyEvents("datadog.ProfilerCounter");
+      long contentionDrops = 0;
+      int countersNum = 0;
+      outer:
+      for (IItemIterable counters : profilerCounters) {
+          countersNum++;
+          IMemberAccessor<String, IItem> nameAccessor = NAME.getAccessor(counters.getType());
+          IMemberAccessor<IQuantity, IItem> countAccessor = COUNT.getAccessor(counters.getType());
+          for (IItem item : counters) {
+              String name = nameAccessor.getMember(item);
+              if ("calltrace_storage_dropped_traces".equals(name)) {
+                  IQuantity value = countAccessor.getMember(item);
+                  if (value != null) {
+                      contentionDrops = value.longValue();
+                      break outer;
+                  }
+              }
+          }
+      }
+      assertTrue(countersNum > 0, "There should be at least one profiler counter");
+      System.out.println("Contention drops detected: " + contentionDrops);
+  }
 }

ddprof-test/src/test/java/com/datadoghq/profiler/cpu/ContextCpuTest.java

@@ -51,6 +51,7 @@ public void test(@CStack String cstack) throws ExecutionException, InterruptedEx
         stopProfiler();
 
         verifyCStackSettings();
+        checkContentionDrops();
 
         Set<Long> method1SpanIds = profiledCode.spanIdsForMethod("method1Impl");
         Set<Long> method2SpanIds = profiledCode.spanIdsForMethod("method2Impl");

ddprof-test/src/test/java/com/datadoghq/profiler/metadata/MetadataNormalisationTest.java

@@ -6,6 +6,7 @@
 import org.openjdk.jmc.common.item.IItemCollection;
 import org.openjdk.jmc.common.item.IItemIterable;
 import org.openjdk.jmc.common.item.IMemberAccessor;
+import org.openjdk.jmc.common.unit.IQuantity;
 import org.openjdk.jmc.flightrecorder.jdk.JdkAttributes;
 
 import java.lang.reflect.Constructor;
@@ -18,6 +19,7 @@
 import java.util.stream.Stream;
 
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class MetadataNormalisationTest extends AbstractProfilerTest {
 
@@ -42,6 +44,9 @@ public void test() throws Exception {
         System.out.println(count);
         stopProfiler();
         IItemCollection executionSamples = verifyEvents("datadog.ExecutionSample");
+        
+        checkContentionDrops();
+
         Matcher[] forbiddenPatternMatchers = Stream.of(
                 "MH.*0x[A-Fa-f0-9]{3}", // method handles
                         "GeneratedConstructorAccessor\\d+",