Always prepare reports #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks [x86_64 wall]Parameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 22 unstable metrics.
|
Benchmarks [x86_64 memleak]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 12 metrics, 23 unstable metrics.
|
Benchmarks [x86_64 cpu]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 12 metrics, 23 unstable metrics.
|
Benchmarks [x86_64 alloc]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 12 metrics, 23 unstable metrics.
|
Benchmarks [aarch64 wall]Parameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 22 unstable metrics.
|
Benchmarks [x86_64 cpu,wall,alloc,memleak]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 22 unstable metrics.
|
Benchmarks [x86_64 cpu,wall]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 12 metrics, 23 unstable metrics.
|
Benchmarks [aarch64 cpu,wall]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 22 unstable metrics.
|
Benchmarks [aarch64 memleak,alloc]Parameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 12 metrics, 21 unstable metrics.
|
Benchmarks [aarch64 cpu,wall,alloc,memleak]Parameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 22 unstable metrics.
|
Benchmarks [aarch64 alloc]Parameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 21 unstable metrics.
|
Benchmarks [aarch64 cpu]Parameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 12 metrics, 22 unstable metrics.
|
Benchmarks [x86_64 memleak,alloc]Parameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 13 metrics, 23 unstable metrics.
|
Benchmarks [aarch64 memleak]Parameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 13 metrics, 20 unstable metrics.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to optimize the workflow by adding a failure() condition to the "Prepare reports" steps so that reports are only prepared when they will be uploaded. However, the changes introduce a critical bug that breaks the unwinding reports functionality.
Key Issue
- The
prepare_reports.shscript prepares both test reports (uploaded on failure) and unwinding reports (uploaded on success) - Adding
failure()to the "Prepare reports" steps prevents unwinding reports from being prepared when tests succeed - This breaks the "Upload unwinding reports" step which runs on
success() && matrix.config == 'debug'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jbachorik
force-pushed
the
jb/gh_fix_prepare_reports
branch
from
7450f0e to
347c41b
Compare
jbachorik
changed the title
jbachorik
force-pushed
the
jb/gh_fix_prepare_reports
branch
from
347c41b to
9727b51
Compare
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial fix to always prepare reports.
The test reports are uploaded only on failure but they were generated only on success (default condition).
Note: The perf regression was introduced in TLS priming and #303 is working on dealing with it
Unsure? Have a question? Request a review!