Apply suggestions from code review

ocaisa · web-flow · commit 4ca595fb19d5 · 2025-06-17T12:29:04.000+02:00
diff --git a/install_scripts.sh b/install_scripts.sh
@@ -55,7 +55,8 @@ sed_update_if_changed() {
     }
 
     if ! diff -q "$file" "$tmp_file" > /dev/null; then
-        mv "$tmp_file" "$file"
+        # Use cat to retain existing permissions, set umask to world readable in case the target file does not yet exist. 
+        (umask 022 && cat "$tmp_file" > "$file")
     else
         rm -f "$tmp_file"
     fi

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ sed_update_if_changed() {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`if ! diff -q "$file" "$tmp_file" > /dev/null; then`
`58`		`- mv "$tmp_file" "$file"`
	`58`	`+ # Use cat to retain existing permissions, set umask to world readable in case the target file does not yet exist.`
	`59`	`+ (umask 022 && cat "$tmp_file" > "$file")`
`59`	`60`	`else`
`60`	`61`	`rm -f "$tmp_file"`
`61`	`62`	`fi`