Disable some naming cops inline

Author: esoterik

.rubocop_todo.yml

@@ -6,39 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-Naming/AccessorMethodName:
-  Exclude:
-    - 'spec/requests/congress_messages_spec.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 2
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-Naming/BlockParameterName:
-  Exclude:
-    - 'app/views/action_page/index.atom.builder'
-    - 'app/views/action_page/index.json.jbuilder'
-
-# Offense count: 3
-# Configuration parameters: EnforcedStyleForLeadingUnderscores.
-# SupportedStylesForLeadingUnderscores: disallowed, required, optional
-Naming/MemoizedInstanceVariableName:
-  Exclude:
-    - 'app/controllers/tools_controller.rb'
-    - 'app/models/action_page.rb'
-    - 'lib/related_content.rb'
-
-# Offense count: 7
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
-Naming/MethodParameterName:
-  Exclude:
-    - 'app/helpers/application_helper.rb'
-    - 'app/mailers/user_mailer.rb'
-    - 'app/models/congress_message_campaign.rb'
-    - 'app/models/institution.rb'
-    - 'app/queries/action_page_filters.rb'
-
 # Offense count: 3
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
@@ -48,9 +15,6 @@ Naming/MethodParameterName:
 Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
-    - 'app/models/source_file.rb'
-    - 'app/models/twitter.rb'
-    - 'lib/congress_forms.rb'
 
 # Offense count: 45
 # Configuration parameters: EnforcedStyle.

app/controllers/tools_controller.rb

@@ -154,9 +154,11 @@ def set_user
     @user = current_user
   end
 
-  def set_action_page
+  # rubocop:todo Naming/MemoizedInstanceVariableName
+  def set_action_page # rubocop:todo Naming/MemoizedInstanceVariableName
     @action_page ||= ActionPage.find_by(id: params[:action_id])
   end
+  # rubocop:enable Naming/MemoizedInstanceVariableName
 
   def create_newsletter_subscription
     if params[:subscribe] && EmailValidator.valid?(params[:subscription][:email])

app/helpers/application_helper.rb

@@ -110,7 +110,7 @@ def messages
     safe_join(messages)
   end
 
-  def percentage(x, y, precision: 0)
+  def percentage(x, y, precision: 0) # rubocop:todo Naming/MethodParameterName
     return "-" unless y > 0
 
     number_to_percentage((x / y.to_f) * 100, precision: precision)

app/mailers/user_mailer.rb

@@ -4,13 +4,15 @@ class UserMailer < ActionMailer::Base
   layout "email"
   after_action :check_bounces
 
+  # rubocop:todo Naming/MethodParameterName
   def thanks_message(email, actionPage, options = {})
     @email = email
     @user = options[:user]
     @actionPage = actionPage
     @name = options[:name].presence || "Friend of Digital Freedom"
     mail(to: email, subject: "Thanks for taking action")
   end
+  # rubocop:enable Naming/MethodParameterName
 
   def signup_attempt_with_existing_email(user, _options = {})
     @user = user

app/models/action_page.rb

@@ -147,11 +147,13 @@ def image
     [og_image, background_image, featured_image].find(&:present?)
   end
 
+  # rubocop:todo Naming/MemoizedInstanceVariableName
   def actions_taken_percent
     return 0 if view_count == 0
 
     @percent ||= (action_count / view_count.to_f) * 100
   end
+  # rubocop:enable Naming/MemoizedInstanceVariableName
 
   def status
     if archived?

app/models/congress_message_campaign.rb

@@ -50,7 +50,7 @@ def member_fills_url
     CongressForms.member_fills_url(campaign_tag)
   end
 
-  def target_bioguide_list=(x)
+  def target_bioguide_list=(x) # rubocop:todo Naming/MethodParameterName
     self.target_bioguide_ids = x.map(&:presence).compact.join(",")
   end
 

app/models/institution.rb

@@ -45,7 +45,7 @@ def self.categories
 
   # Sort institutions by most popular.
   # Put `first` at the top of the list if it exists.
-  def self.top(n, first: 0)
+  def self.top(n, first: 0) # rubocop:todo Naming/MethodParameterName
     select("institutions.*, COUNT(signatures.id) AS s_count")
       .joins("LEFT OUTER JOIN affiliations ON institutions.id = affiliations.institution_id")
       .joins("LEFT OUTER JOIN signatures ON affiliations.signature_id = signatures.id")

app/models/source_file.rb

@@ -56,7 +56,7 @@ def to_jq_upload
     }
   end
 
-  def is_image?
+  def is_image? # rubocop:todo Naming/PredicateName
     !!file_content_type.try(:match, /image/)
   end
 

app/models/twitter.rb

@@ -1,5 +1,5 @@
 class Twitter
-  def self.has_api_keys?
+  def self.has_api_keys? # rubocop:todo Naming/PredicateName
     Rails.application.secrets.twitter_api_key.present? &&
       Rails.application.secrets.twitter_api_secret.present? &&
       Rails.application.secrets.twitter_oauth_token.present? &&

app/queries/action_page_filters.rb

@@ -46,12 +46,12 @@ def parse_date_range
     filters[:date_range].split(" - ").map { |d| Time.zone.parse(d) }
   end
 
-  def valid_query?(f, val)
+  def valid_query?(f, val) # rubocop:todo Naming/MethodParameterName
     validate_filter_name f
     !empty_value? val
   end
 
-  def validate_filter_name(f)
+  def validate_filter_name(f) # rubocop:todo Naming/MethodParameterName
     raise ArgumentError, "unrecognized filter #{f}" unless VALID_FILTERS.include? f
   end
 end