Merge pull request #237 from EasyPost/concatenate_error_message

fix: concatenates error.message if it is a list

Author: Justintime50

CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## NEXT RELEASE
+
+- Concatenates `error.message` if it incorrectly comes back from the API as a list
+
 ## v7.6.0 (2022-09-21)
 
 - Adds support to pass `end_shipper_id` on the buy call of a Shipment

easypost/error.py

@@ -8,13 +8,15 @@
 class Error(Exception):
     def __init__(
         self,
-        message: Optional[str] = None,
+        message: Optional[
+            Union[str, list]
+        ] = None,  # message should be a string but can sometimes incorrectly come back as a list
         http_status: Optional[int] = None,
         http_body: Optional[Union[str, bytes]] = None,
         original_exception: Optional[Exception] = None,
     ):
         super(Error, self).__init__(message)
-        self.message = message
+        self.message = ", ".join(message) if type(message) == list else message
         self.http_status = http_status
         self.http_body = http_body
         self.original_exception = original_exception

tests/test_error.py

@@ -21,3 +21,12 @@ def test_error_no_json():
     error = easypost.Error(http_body="bad json")
 
     assert error.json_body is None
+
+
+def test_error_list_message():
+    """Tests that we concatenate error messages that are a list (they should be a string from the
+    API but aren't always so we protect against that here).
+    """
+    error = easypost.Error(message=["Error1", "Error2"])
+
+    assert error.message == "Error1, Error2"