Skip to content

request from defaults() method ignores options argument in some cases. #86

@axfree

Description

@axfree

request from defaults() method ignores options argument in some cases.

var request = require('requestretry').defaults({
    headers: {
        'User-Agent': 'default UA'
    }
});

// OK
request('https://github.com/', function (err, response, body) {
});

// NOT OK - Referer header is not sent
request('https://github.com/', {
    headers: {
        Referer: 'https://www.apple.com/'
    }
}, function (err, response, body) {
});

// OK
request({
    url: 'https://github.com/',
    headers: {
        Referer: 'https://www.apple.com/'
    }
}, function (err, response, body) {
});

// OK
request.get('https://github.com/', {
    headers: {
        Referer: 'https://www.apple.com/'
    }
}, function (err, response, body) {
});

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions