From 241787a460eb9053e19de97900d5372c4a049f6a Mon Sep 17 00:00:00 2001 From: Suchita Lad Date: Fri, 20 Jun 2025 17:29:28 +0530 Subject: [PATCH 1/3] Updated xpath part to remove all splitblocks --- blocks/eda-frontend/public/splitblock.xsl | 8 +++---- blocks/eda-frontend/src/utils/GalleryUtils.js | 4 ++-- blocks/xcos2xml/replacesplitblocks.sh | 21 +++++++++++++------ 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/blocks/eda-frontend/public/splitblock.xsl b/blocks/eda-frontend/public/splitblock.xsl index d6299c6a..974b24c3 100644 --- a/blocks/eda-frontend/public/splitblock.xsl +++ b/blocks/eda-frontend/public/splitblock.xsl @@ -624,7 +624,7 @@ - + @@ -1061,9 +1061,9 @@ - + - + @@ -1076,7 +1076,7 @@ - + diff --git a/blocks/eda-frontend/src/utils/GalleryUtils.js b/blocks/eda-frontend/src/utils/GalleryUtils.js index 37322592..0e5c618e 100644 --- a/blocks/eda-frontend/src/utils/GalleryUtils.js +++ b/blocks/eda-frontend/src/utils/GalleryUtils.js @@ -33,7 +33,7 @@ const getSplitXsltProcessor = async () => { return processor } -const splitBlockXPathCount = 'count(/XcosDiagram/mxGraphModel/root/SplitBlock)' +const splitBlockXPathCount = 'count(//SplitBlock)' const countNodesByXPath = (xpath, contextNode) => { const result = contextNode.evaluate(xpath, contextNode, null, XPathResult.NUMBER_TYPE, null) @@ -62,7 +62,7 @@ const removeOneSplit = (xmlDoc, count, splitProcessor) => { xmlDoc = splitProcessor.transformToDocument(xmlDoc) const newCount = countNodesByXPath(splitBlockXPathCount, xmlDoc) - if (newCount !== count - 1) { + if (newCount >= count) { console.error('newCount=', newCount, ', count=', count) throw new Error('count mismatch') } diff --git a/blocks/xcos2xml/replacesplitblocks.sh b/blocks/xcos2xml/replacesplitblocks.sh index 0b5f751a..24058921 100755 --- a/blocks/xcos2xml/replacesplitblocks.sh +++ b/blocks/xcos2xml/replacesplitblocks.sh @@ -92,7 +92,8 @@ if test -n "$INPUTXML"; then Xcos/MxGraphParser.py "$INPUTXML" "$WORKSPACE" "$CONTEXT" fi -count=$(grep -c '^ "$TMPFILE1" xmllint --format "$TMPFILE1" >"$TMPFILE2" - count=$(grep -c '^ = oldcount)); then + echo "ERROR: SplitBlock count did not decrease (old=$oldcount, new=$count)" >&2 + exit 2 + fi INPUT1="$BASE-$count.xml" echo "Creating $INPUT1" cp -f "$TMPFILE2" "$INPUT1" - if ((count != oldcount - 1)); then - echo "ERROR: $count != $oldcount - 1" >&2 - exit 2 - fi + # if ((count != oldcount - 1)); then + # if ((count < oldcount)); then + # # echo "ERROR: $count != $oldcount - 1" >&2 + # echo "ERROR: $count < $oldcount" >&2 + # exit 2 + # fi done xsltproc "$XSL" "$INPUT1" >"$TMPFILE1" From d5ff5deb060b34803fe90998367a8b0a904d0805 Mon Sep 17 00:00:00 2001 From: Suchita Lad Date: Thu, 24 Jul 2025 11:37:11 +0530 Subject: [PATCH 2/3] Updated xpath of splitblock --- blocks/eda-frontend/public/splitblock.xsl | 6 +++--- blocks/xcos2xml/replacesplitblocks.sh | 10 ---------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/blocks/eda-frontend/public/splitblock.xsl b/blocks/eda-frontend/public/splitblock.xsl index 974b24c3..f59e9fc3 100644 --- a/blocks/eda-frontend/public/splitblock.xsl +++ b/blocks/eda-frontend/public/splitblock.xsl @@ -1061,9 +1061,9 @@ - + - + @@ -1076,7 +1076,7 @@ - + diff --git a/blocks/xcos2xml/replacesplitblocks.sh b/blocks/xcos2xml/replacesplitblocks.sh index 24058921..4c5a9c25 100755 --- a/blocks/xcos2xml/replacesplitblocks.sh +++ b/blocks/xcos2xml/replacesplitblocks.sh @@ -92,7 +92,6 @@ if test -n "$INPUTXML"; then Xcos/MxGraphParser.py "$INPUTXML" "$WORKSPACE" "$CONTEXT" fi -# count=$(grep -c '^ "$TMPFILE1" xmllint --format "$TMPFILE1" >"$TMPFILE2" - # count=$(grep -c '^ = oldcount)); then echo "ERROR: SplitBlock count did not decrease (old=$oldcount, new=$count)" >&2 exit 2 @@ -113,13 +110,6 @@ while test $count -gt 0; do INPUT1="$BASE-$count.xml" echo "Creating $INPUT1" cp -f "$TMPFILE2" "$INPUT1" - - # if ((count != oldcount - 1)); then - # if ((count < oldcount)); then - # # echo "ERROR: $count != $oldcount - 1" >&2 - # echo "ERROR: $count < $oldcount" >&2 - # exit 2 - # fi done xsltproc "$XSL" "$INPUT1" >"$TMPFILE1" From 7bfc18f2e4a368c1838dc8855b699c61ef0904e7 Mon Sep 17 00:00:00 2001 From: Suchita Lad Date: Fri, 25 Jul 2025 11:44:42 +0530 Subject: [PATCH 3/3] Updated condition for removal of port and links of splitblock --- blocks/eda-frontend/public/splitblock.xsl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/blocks/eda-frontend/public/splitblock.xsl b/blocks/eda-frontend/public/splitblock.xsl index f59e9fc3..dd239324 100644 --- a/blocks/eda-frontend/public/splitblock.xsl +++ b/blocks/eda-frontend/public/splitblock.xsl @@ -1063,7 +1063,7 @@ - + @@ -1077,13 +1077,13 @@ - + - +