Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261
Some thoughts on the issue:
Several Markdown implementations allow for an optional feature called front matter, which allows the user to add metadata in YAML format at the start of a Markdown file, surrounded by three dashes.
markdown-oxidedoes support a small subset of it through its alias feature, which allows a user to add alternative names to the current file. The issue occurs when a comment is present in the front matter section. YAML comments are captured as headings, which is not desired.Overview of the changes in this PR:
src/vault/metadata.rswas extended to allow theMDMetadatastruct to hold comments.MDFile::new()onsrc/vault/mod.rswas modified: the metadata is captured before the headings, which are filtered to ignore headings that are actually metadata.Edit: accidentally included an unwanted commit, will fix.
Edit: fixed.