Skip to content

Fix monorepo build args split and add test for getBuildOptions #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 9, 2025
Merged

Fix monorepo build args split and add test for getBuildOptions #376

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b3f5783
Fix monorepo build args split
sjjj986 Aug 4, 2025
a5f1413
Merge remote-tracking branch 'origin/main' into sijinli-turbo-build-a…
sjjj986 Aug 5, 2025
dda4ccb
add test for getBuildOptions
sjjj986 Aug 8, 2025
4585bf7
lint
sjjj986 Aug 8, 2025
79ec20f
update test description
sjjj986 Aug 8, 2025
c963ea1
Merge branch 'main' into sijinli-turbo-build-args-fix
sjjj986 Aug 9, 2025
175c3fb
remove comment
sjjj986 Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@apphosting/common/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function getBuildOptions(): BuildOptions {
if (process.env.MONOREPO_COMMAND) {
return {
buildCommand: process.env.MONOREPO_COMMAND,
buildArgs: ["run", "build"].concat(process.env.MONOREPO_BUILD_ARGS?.split(".") || []),
buildArgs: ["run", "build"].concat(process.env.MONOREPO_BUILD_ARGS?.split(",") || []),
projectDirectory: process.env.GOOGLE_BUILDABLE || "",
projectName: process.env.MONOREPO_PROJECT,
};
Expand Down