v3.0.0-rc.1

[jhuleatt]

• Mark startWithValue deprecated and alias it to initialData (Mark startWithValue deprecated and alias it to initialData #310)
• SuspenseWithPerf jsdom compatibility (FIX #322: SuspenseWithPerf jsdom compatibility #324)
• Obey the Rules of Hooks (Obey the Rules of Hooks #367)
• Update Firestore generics (update firestore generics #366)
• Set hasEmitted for initialData (Set hasEmitted for initialData #370)
• Deprecate AuthCheck and ClaimsCheck components in favor of useSigninCheck hook (New Auth Hook: useSigninCheck() to replace AuthCheck and ClaimsCheck components #368)
• useSdk: only check hasValue if suspense mode (only check hasValue if suspense mode is true #373)
• Update rxfire and rxjs (Update rxfire and rxjs #372)

---

This discussion was created from the release v3.0.0-rc.1.

[Smith4170]

Error on app compile:

Failed to compile
./node_modules/rxfire/database/index.esm.js
Attempted import error: '__spreadArray' is not exported from 'tslib'.

[jhuleatt]

@Smith4170 thanks for trying out the new release candidate! I can't reproduce that error with the example in this repo or on the StackBlitz sample. Can you please file an issue with some more detail about your setup (preferably a simple app that reproduces the issue)?

[epodol]

I'm also having this issue. The repo is available here: https://github.com/epodol/bsclibrary. The only change I have made is update reactfire to v3.0.0-rc.1. I'm continuing to investigate and then I'll open an issue with my findings, or just post here how I solved it.

This issue has been solved by updating to v3.0.0-rc.2.

[conrado]

the example app seems to be throwing some errors on Storage component, for image upload

[jhuleatt]

Hey @conrado, thanks for trying it out! That _warmupSubscription undefined error should have been fixed in the latest build. The example app points at your local build of ReactFire, can you please confirm that you've rebuilt the library, or can you make the example/package.json file to point to v3.0.0-rc.1 with the following change:

  "dependencies": {
    "display": "^0.1.9",
    "react-app-polyfill": "^1.0.0",
    "react-firebaseui": "^4.2.0",
    "tailwindcss": "^1.9.1",
+  "reactfire": "v3.0.0-rc.1"
  },
  "alias": {
    "react": "../node_modules/react",
    "react-dom": "../node_modules/react-dom",
-    "reactfire": "../."
  },

and see if it still happens?

[conrado]

issuing a rebuild worked just fine, thank you for the hint

[conrado]

I noticed the ConcurrentModeApp component was completely disabled, any chance concurrent mode will make it back?

[jhuleatt]

It's still there, it's just that react@experimental is now React 18 and throws some errors it didn't used to when you use it in non-concurrent-mode, so I wanted to keep the repo on React 17. If you install react@experimental and react-dom@experimental and swap out to the ConcurrentModeApp in the example, it should all still work:

reactfire/example/index.tsx

Lines 4 to 11 in 4d1206d

	/**
	* Use this instead of NonConcurrentModeApp to see a ReactFire demo with Suspense/Concurrent mode enabled
	*
	* You'll need to use an experimental build of React to use Concurrent mode
	* https://reactjs.org/docs/concurrent-mode-adoption.html#installation
	*/
	// import { AppWrapper as ConcurrentModeApp } from './withSuspense/App';
	import { App as NonConcurrentModeApp } from './withoutSuspense/App';

[conrado]

I'm happy to help with testing and contributing code. Particularly interested in looking into getting the emulators running 100%, though I might need a little guidance and clues

[jhuleatt]

Awesome, that would be a huge help! Now is a bit of a tricky time to start contributing because we're working on migrating to Firebase v9 in #369, which involves some major changes. Once we have a mostly-working build with v9, we'd definitely appreciate lots of testing and contributions!