Skip to content

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Dec 16, 2025

Enacts the following change for C++ plugins:

<plugin_label> : {
-  plugin: "my_cpp_plugin"
+  cpp: "my_cpp_plugin"
}

and the following change for Python plugins:

<plugin_label> : {
-  plugin: "pymodule"
-  pyplugin: "my_python_module.py"
+  py: "my_python_module"
}

Note that, for Python plugins, the cpp: "pymodule" configuration is automatically inserted into the configuration if the py: ... parameter is present.


@knoepfel knoepfel marked this pull request as draft December 16, 2025 21:59
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.31%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   76.47%   76.31%   -0.17%     
==========================================
  Files         124      124              
  Lines        2737     2748      +11     
  Branches      472      476       +4     
==========================================
+ Hits         2093     2097       +4     
- Misses        449      454       +5     
- Partials      195      197       +2     
Flag Coverage Δ
unittests 76.31% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/app/load_module.cpp 85.00% <100.00%> (+5.68%) ⬆️
plugins/python/src/pymodule.cpp 64.58% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71457e0...0cc6022. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the plugin-language branch 2 times, most recently from c9d8abf to aafdd00 Compare December 18, 2025 19:15
@knoepfel
Copy link
Member Author

@phlexbot format

@github-actions
Copy link
Contributor

No automatic clang-format fixes were necessary.

@github-actions
Copy link
Contributor

Automatic cmake-format fixes pushed (commit 20d108e).
⚠️ Note: Some issues may require manual review and fixing.

@knoepfel knoepfel marked this pull request as ready for review December 19, 2025 19:23
@marcpaterno marcpaterno self-requested a review December 19, 2025 19:24
@knoepfel
Copy link
Member Author

@phlexbot format

@github-actions
Copy link
Contributor

No automatic clang-format fixes were necessary.

@github-actions
Copy link
Contributor

Automatic cmake-format fixes pushed (commit cfedc26).
⚠️ Note: Some issues may require manual review and fixing.

@knoepfel knoepfel merged commit 5392a32 into Framework-R-D:main Dec 19, 2025
35 of 36 checks passed
@knoepfel knoepfel deleted the plugin-language branch December 19, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signify plugin language via cpp or py parameter

2 participants